Bug 170092 - Statically link libwebrtc
Summary: Statically link libwebrtc
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-24 17:52 PDT by Alex Christensen
Modified: 2017-04-05 18:52 PDT (History)
5 users (show)

See Also:


Attachments
patch (24.70 KB, patch)
2017-03-24 17:54 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-03-24 17:52:51 PDT
Enough of this libwebrtc.dylib nonsense.  It isn't worth having a complicated production build system that only one person understands.
Comment 1 Alex Christensen 2017-03-24 17:54:43 PDT
Created attachment 305346 [details]
patch
Comment 2 Joseph Pecoraro 2017-03-24 20:08:07 PDT
Comment on attachment 305346 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305346&action=review

> Source/WebCore/ChangeLog:12
> +        * Configurations/WebCoreTestSupport.xcconfig:

Should this eliminate the code in Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp that attempts to dlopen("libwebrtc.dylib")?
Comment 3 mitz 2017-03-24 20:44:41 PDT
I believe that there are Apple-internal reasons for libwebrtc being a dylib, seen in <rdar://problem/30470169&30470847>.
Comment 4 youenn fablet 2017-03-24 20:45:40 PDT
I would do that if we cannot upstream the WEBRTC_DYLIB_EXPORT changes to libwebrtc.
Given where we are, I do not have a strong opinion, although that would simplify the build system which is a good thing.
Also, if we are doing so, the webcore binary size will increase a bit.
Some code would be removed like webrtAvailable check.
Comment 5 Maciej Stachowiak 2017-03-24 21:13:44 PDT
We need to discuss the Apple-internal implications (not in these bug comments, but Apple-internally) before we make the call on this.