WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
170086
Add some instrumentation in Heap::resumeThePeriphery() to help debug an issue.
https://bugs.webkit.org/show_bug.cgi?id=170086
Summary
Add some instrumentation in Heap::resumeThePeriphery() to help debug an issue.
Mark Lam
Reported
2017-03-24 16:54:45 PDT
Adding some instrumentation in Heap::resumeThePeriphery() to dump some Heap state just before we RELEASE_ASSERT_NOT_REACHED.
Attachments
proposed patch.
(2.04 KB, patch)
2017-03-24 17:56 PDT
,
Mark Lam
saam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2017-03-24 16:55:40 PDT
<
rdar://problem/31253673
>
Mark Lam
Comment 2
2017-03-24 17:56:12 PDT
Created
attachment 305347
[details]
proposed patch.
Saam Barati
Comment 3
2017-03-24 20:48:55 PDT
Comment on
attachment 305347
[details]
proposed patch. View in context:
https://bugs.webkit.org/attachment.cgi?id=305347&action=review
> Source/JavaScriptCore/heap/Heap.cpp:1502 > +#if OS(DARWIN)
Can you also put a FIXME here with a bug number so we can consider removing this once we find the bug?
Mark Lam
Comment 4
2017-03-24 22:35:26 PDT
(In reply to Saam Barati from
comment #3
)
> Can you also put a FIXME here with a bug number so we can consider removing > this once we find the bug?
Thanks for the review. I've added the FIXME with bug
https://bugs.webkit.org/show_bug.cgi?id=170094
. Landed in
r214393
: <
http://trac.webkit.org/r214393
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug