Bug 170086 - Add some instrumentation in Heap::resumeThePeriphery() to help debug an issue.
Summary: Add some instrumentation in Heap::resumeThePeriphery() to help debug an issue.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-24 16:54 PDT by Mark Lam
Modified: 2017-03-24 22:35 PDT (History)
6 users (show)

See Also:


Attachments
proposed patch. (2.04 KB, patch)
2017-03-24 17:56 PDT, Mark Lam
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2017-03-24 16:54:45 PDT
Adding some instrumentation in Heap::resumeThePeriphery() to dump some Heap state just before we RELEASE_ASSERT_NOT_REACHED.
Comment 1 Radar WebKit Bug Importer 2017-03-24 16:55:40 PDT
<rdar://problem/31253673>
Comment 2 Mark Lam 2017-03-24 17:56:12 PDT
Created attachment 305347 [details]
proposed patch.
Comment 3 Saam Barati 2017-03-24 20:48:55 PDT
Comment on attachment 305347 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=305347&action=review

> Source/JavaScriptCore/heap/Heap.cpp:1502
> +#if OS(DARWIN)

Can you also put a FIXME here with a bug number so we can consider removing this once we find the bug?
Comment 4 Mark Lam 2017-03-24 22:35:26 PDT
(In reply to Saam Barati from comment #3)
> Can you also put a FIXME here with a bug number so we can consider removing
> this once we find the bug?

Thanks for the review.  I've added the FIXME with bug https://bugs.webkit.org/show_bug.cgi?id=170094.

Landed in r214393: <http://trac.webkit.org/r214393>.