Bug 170084 - Add ARM64 system instructions to disassembler
Summary: Add ARM64 system instructions to disassembler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-24 16:28 PDT by Michael Saboff
Modified: 2017-03-27 09:40 PDT (History)
5 users (show)

See Also:

Attachments
Patch (8.38 KB, patch)
2017-03-24 16:34 PDT, Michael Saboff 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2017-03-24 16:28:23 PDT 
Now that we are emitting mrs instructions, they should be added to the ARM64 disassembler.
Comment 1 Michael Saboff 2017-03-24 16:34:50 PDT 
Created attachment 305337 [details]
Patch
Comment 2 JF Bastien 2017-03-24 16:52:19 PDT 
Comment on attachment 305337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305337&action=review

lgtm

> Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.cpp:896
> +        pstateField = "daifclr";

The manual capitalizes these: SPSel, DAIFSet, DAIFClr.
Comment 3 Saam Barati 2017-03-24 18:43:41 PDT 
Comment on attachment 305337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305337&action=review

> Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h:559
> +    class A64DOpcodeMSROrMRSRegister : public A64DOpcodeSystem {

Style: indentation is off
Comment 4 Michael Saboff 2017-03-27 09:38:04 PDT 
(In reply to Saam Barati from comment #3)
> Comment on attachment 305337 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=305337&action=review
> 
> > Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h:559
> > +    class A64DOpcodeMSROrMRSRegister : public A64DOpcodeSystem {
> 
> Style: indentation is off

Fixed.

I kept the special register lowercase as that is intentional and I think it looks a little better.
Comment 5 Michael Saboff 2017-03-27 09:40:40 PDT 
Fix landed in change set r214416: <http://trac.webkit.org/changeset/214416>