Bug 170084 – Add ARM64 system instructions to disassembler

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Michael Saboff]

Now that we are emitting mrs instructions, they should be added to the ARM64 disassembler.

[Michael Saboff]

Created attachment 305337 [details]
Patch

[JF Bastien]

Comment on attachment 305337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305337&action=review

lgtm

> Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.cpp:896
> +        pstateField = "daifclr";

The manual capitalizes these: SPSel, DAIFSet, DAIFClr.

[Saam Barati]

Comment on attachment 305337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305337&action=review

> Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h:559
> +    class A64DOpcodeMSROrMRSRegister : public A64DOpcodeSystem {

Style: indentation is off

[Michael Saboff]

(In reply to Saam Barati from comment #3)
> Comment on attachment 305337 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=305337&action=review
> 
> > Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h:559
> > +    class A64DOpcodeMSROrMRSRegister : public A64DOpcodeSystem {
> 
> Style: indentation is off

Fixed.

I kept the special register lowercase as that is intentional and I think it looks a little better.

[Michael Saboff]

Fix landed in change set r214416: <http://trac.webkit.org/changeset/214416>