Bug 170078 - webkitpy: Use generalized device instead of platform specific one
Summary: webkitpy: Use generalized device instead of platform specific one
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-24 15:41 PDT by Jonathan Bedard
Modified: 2017-03-25 07:44 PDT (History)
5 users (show)

See Also:


Attachments
Patch (10.11 KB, patch)
2017-03-24 15:44 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (11.84 KB, patch)
2017-03-24 16:00 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (12.28 KB, patch)
2017-03-24 16:36 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2017-03-24 15:41:36 PDT
When testing on devices, pass a generalized device interface instead of a specific platform device.  The generalized device should be persistent.
Comment 1 Jonathan Bedard 2017-03-24 15:44:04 PDT
Created attachment 305327 [details]
Patch
Comment 2 Jonathan Bedard 2017-03-24 16:00:48 PDT
Created attachment 305331 [details]
Patch
Comment 3 Daniel Bates 2017-03-24 16:12:44 PDT
Comment on attachment 305331 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305331&action=review

> Tools/ChangeLog:10
> +        no longer inherits from Device and IOSSimulator returns Devices
> +        wrapping SimulatedDevices.

We should explain why we are making this change.
Comment 4 Radar WebKit Bug Importer 2017-03-24 16:29:50 PDT
<rdar://problem/31253119>
Comment 5 Jonathan Bedard 2017-03-24 16:36:19 PDT
Created attachment 305338 [details]
Patch
Comment 6 WebKit Commit Bot 2017-03-25 07:44:29 PDT
Comment on attachment 305338 [details]
Patch

Clearing flags on attachment: 305338

Committed r214399: <http://trac.webkit.org/changeset/214399>
Comment 7 WebKit Commit Bot 2017-03-25 07:44:33 PDT
All reviewed patches have been landed.  Closing bug.