Summary: Resource Details Sidebar displays previous image metrics when viewing resource where content load failed Steps to Reproduce: 1. Inspect https://web.whatsapp.com 2. Reload so we get all Image resources 3. Select a data:image/png image resource => Details Sidebar shows correct image size 4. Select a data:image/webp image resource => Details Sidebar shows previous image's size Notes: The frontend failed to load the content, so it should return a failure to the sidebar to update its display in some way (either dashes or remove the section).
<rdar://problem/27081591>
Created attachment 305306 [details] [PATCH] Proposed Fix
Comment on attachment 305306 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=305306&action=review > Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js:458 > + } else > + hideImageSection.call(this); An alternative would be to show the section and have emdash values. But seeing as we hide the section above if the `resource.failed` I matched that here.
Comment on attachment 305306 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=305306&action=review >> Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js:458 >> + hideImageSection.call(this); > > An alternative would be to show the section and have emdash values. But seeing as we hide the section above if the `resource.failed` I matched that here. r=me. I like this approach, rather than showing emdash values. Cuts down on clutter.
Comment on attachment 305306 [details] [PATCH] Proposed Fix Clearing flags on attachment: 305306 Committed r214436: <http://trac.webkit.org/changeset/214436>
All reviewed patches have been landed. Closing bug.