WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
170059
[GTK] No value returned from PrintCustomWidgetTest::createWebKitPrintOperation() in TestPrinting.cpp
https://bugs.webkit.org/show_bug.cgi?id=170059
Summary
[GTK] No value returned from PrintCustomWidgetTest::createWebKitPrintOperatio...
Adrian Perez
Reported
2017-03-24 10:51:11 PDT
Clang finds this when building WebKitGTK+: Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:402:5: warning: control may reach end of non-void function [-Wreturn-type] The function is declared as returning a “WebKitPrintOperation*”, but there is no “return“ statement. Also, where the method is used the result of the call is not used. I'm sending a one-liner for this.
Attachments
Patch
(1.42 KB, patch)
2017-03-24 10:58 PDT
,
Adrian Perez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adrian Perez
Comment 1
2017-03-24 10:58:57 PDT
Created
attachment 305298
[details]
Patch
WebKit Commit Bot
Comment 2
2017-03-25 01:35:11 PDT
Comment on
attachment 305298
[details]
Patch Clearing flags on attachment: 305298 Committed
r214398
: <
http://trac.webkit.org/changeset/214398
>
WebKit Commit Bot
Comment 3
2017-03-25 01:35:14 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug