Bug 170059 - [GTK] No value returned from PrintCustomWidgetTest::createWebKitPrintOperation() in TestPrinting.cpp
Summary: [GTK] No value returned from PrintCustomWidgetTest::createWebKitPrintOperatio...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-24 10:51 PDT by Adrian Perez
Modified: 2017-03-25 01:35 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.42 KB, patch)
2017-03-24 10:58 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2017-03-24 10:51:11 PDT 
Clang finds this when building WebKitGTK+:

  Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:402:5: warning: control may reach end of non-void function [-Wreturn-type]

The function is declared as returning a “WebKitPrintOperation*”, but there is
no “return“ statement. Also, where the method is used the result of the call
is not used.

I'm sending a one-liner for this.
Comment 1 Adrian Perez 2017-03-24 10:58:57 PDT 
Created attachment 305298 [details]
Patch
Comment 2 WebKit Commit Bot 2017-03-25 01:35:11 PDT 
Comment on attachment 305298 [details]
Patch

Clearing flags on attachment: 305298

Committed r214398: <http://trac.webkit.org/changeset/214398>
Comment 3 WebKit Commit Bot 2017-03-25 01:35:14 PDT 
All reviewed patches have been landed.  Closing bug.