Bug 170056 - [MediaStream] "ideal" constraints passed to getUserMedia should affect fitness score
Summary: [MediaStream] "ideal" constraints passed to getUserMedia should affect fitnes...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-24 09:48 PDT by Eric Carlson
Modified: 2017-03-24 16:27 PDT (History)
3 users (show)

See Also:

Attachments
Proposed patch. (35.46 KB, patch)
2017-03-24 12:22 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Proposed patch. (35.27 KB, patch)
2017-03-24 13:44 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2017-03-24 09:48:27 PDT 
"ideal" constraints passed to getUserMedia should affect fitness score
Comment 1 Eric Carlson 2017-03-24 12:22:08 PDT 
Created attachment 305313 [details]
Proposed patch.
Comment 2 Radar WebKit Bug Importer 2017-03-24 12:23:01 PDT 
<rdar://problem/31247451>
Comment 3 Eric Carlson 2017-03-24 13:44:41 PDT 
Created attachment 305320 [details]
Proposed patch.
Comment 4 youenn fablet 2017-03-24 15:28:54 PDT 
Comment on attachment 305320 [details]
Proposed patch.

LGTM!
Make sure to test LayoutTests/webrtc to check whether some tests break or not before landing.
Comment 5 Eric Carlson 2017-03-24 15:45:18 PDT 
Comment on attachment 305320 [details]
Proposed patch.

This doesn't break any webrtc-specific tests.
Comment 6 WebKit Commit Bot 2017-03-24 16:27:18 PDT 
Comment on attachment 305320 [details]
Proposed patch.

Clearing flags on attachment: 305320

Committed r214385: <http://trac.webkit.org/changeset/214385>
Comment 7 WebKit Commit Bot 2017-03-24 16:27:21 PDT 
All reviewed patches have been landed.  Closing bug.