Bug 170051 - [Modern Media Controls] Captions don't move with the appearance of the inline controls
Summary: [Modern Media Controls] Captions don't move with the appearance of the inline...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-24 06:31 PDT by Antoine Quint
Modified: 2017-03-24 15:10 PDT (History)
2 users (show)

See Also:

Attachments
Patch (15.18 KB, patch)
2017-03-24 06:54 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2017-03-24 06:31:42 PDT 
We need to monitor when the controls bar fades in and out and offset the captions by the size of the controls bar.
Comment 1 Antoine Quint 2017-03-24 06:31:55 PDT 
<rdar://problem/30754428>
Comment 2 Antoine Quint 2017-03-24 06:54:29 PDT 
Created attachment 305280 [details]
Patch
Comment 3 Dean Jackson 2017-03-24 12:25:11 PDT 
Comment on attachment 305280 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305280&action=review

> Source/WebCore/Modules/modern-media-controls/media/media-controller.js:221
> +        this.host.textTrackContainer.classList.toggle("compact-controls-bar", !!(layoutTraits & LayoutTraits.Compact));

I don't think you need the !! here.
Comment 4 Antoine Quint 2017-03-24 12:30:52 PDT 
(In reply to Dean Jackson from comment #3)
> Comment on attachment 305280 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=305280&action=review
> 
> > Source/WebCore/Modules/modern-media-controls/media/media-controller.js:221
> > +        this.host.textTrackContainer.classList.toggle("compact-controls-bar", !!(layoutTraits & LayoutTraits.Compact));
> 
> I don't think you need the !! here.

It's just so that we're passing a boolean in and not a number, which I think is cleaner.
Comment 5 WebKit Commit Bot 2017-03-24 15:10:49 PDT 
Comment on attachment 305280 [details]
Patch

Clearing flags on attachment: 305280

Committed r214381: <http://trac.webkit.org/changeset/214381>
Comment 6 WebKit Commit Bot 2017-03-24 15:10:53 PDT 
All reviewed patches have been landed.  Closing bug.