Bug 170051 – [Modern Media Controls] Captions don't move with the appearance of the inline controls

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Antoine Quint]

We need to monitor when the controls bar fades in and out and offset the captions by the size of the controls bar.

[Antoine Quint]

<rdar://problem/30754428>

[Antoine Quint]

Created attachment 305280 [details]
Patch

[Dean Jackson]

Comment on attachment 305280 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305280&action=review

> Source/WebCore/Modules/modern-media-controls/media/media-controller.js:221
> +        this.host.textTrackContainer.classList.toggle("compact-controls-bar", !!(layoutTraits & LayoutTraits.Compact));

I don't think you need the !! here.

[Antoine Quint]

(In reply to Dean Jackson from comment #3)
> Comment on attachment 305280 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=305280&action=review
> 
> > Source/WebCore/Modules/modern-media-controls/media/media-controller.js:221
> > +        this.host.textTrackContainer.classList.toggle("compact-controls-bar", !!(layoutTraits & LayoutTraits.Compact));
> 
> I don't think you need the !! here.

It's just so that we're passing a boolean in and not a number, which I think is cleaner.

[WebKit Commit Bot]

Comment on attachment 305280 [details]
Patch

Clearing flags on attachment: 305280

Committed r214381: <http://trac.webkit.org/changeset/214381>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.