Bug 170040 - Revert r213712, caused iPad PLT regression
Summary: Revert r213712, caused iPad PLT regression
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 149157
  Show dependency treegraph
 
Reported: 2017-03-23 18:29 PDT by Antti Koivisto
Modified: 2017-03-23 20:20 PDT (History)
3 users (show)

See Also:


Attachments
patch (23.49 KB, patch)
2017-03-23 19:08 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-03-23 18:29:36 PDT
A few subtests have big regressions
Comment 1 Antti Koivisto 2017-03-23 19:08:03 PDT
Created attachment 305258 [details]
patch
Comment 2 Build Bot 2017-03-23 19:09:41 PDT
Attachment 305258 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderBlock.cpp:1582:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/dom/Document.cpp:1869:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/dom/Document.cpp:1872:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 3 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2017-03-23 20:20:22 PDT
Comment on attachment 305258 [details]
patch

Clearing flags on attachment: 305258

Committed r214333: <http://trac.webkit.org/changeset/214333>
Comment 4 WebKit Commit Bot 2017-03-23 20:20:26 PDT
All reviewed patches have been landed.  Closing bug.