Bug 170039 - Move visibleInViewportStateChanged callback from Element to render tree
Summary: Move visibleInViewportStateChanged callback from Element to render tree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-23 17:03 PDT by Antti Koivisto
Modified: 2017-03-27 17:06 PDT (History)
5 users (show)

See Also:


Attachments
patch (12.87 KB, patch)
2017-03-23 17:19 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-03-23 17:03:50 PDT
Make it easier to use from render tree.
Comment 1 Antti Koivisto 2017-03-23 17:19:05 PDT
Created attachment 305249 [details]
patch
Comment 2 Simon Fraser (smfr) 2017-03-23 21:38:36 PDT
Comment on attachment 305249 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305249&action=review

> Source/WebCore/rendering/RenderElement.h:349
> +    unsigned m_visibleInViewportState : 2;

Would be nice to have a comment to say what enum gets stuffed in here.
Comment 3 WebKit Commit Bot 2017-03-27 17:06:32 PDT
Comment on attachment 305249 [details]
patch

Clearing flags on attachment: 305249

Committed r214443: <http://trac.webkit.org/changeset/214443>
Comment 4 WebKit Commit Bot 2017-03-27 17:06:35 PDT
All reviewed patches have been landed.  Closing bug.