Bug 170029 - Web Inspector: DetailsSection should hide header "options" when collapsed
Summary: Web Inspector: DetailsSection should hide header "options" when collapsed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-23 15:43 PDT by Matt Baker
Modified: 2017-04-03 15:07 PDT (History)
3 users (show)

See Also:

Attachments
Patch (11.16 KB, patch)
2017-03-23 15:53 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2017-03-23 15:43:10 PDT 
Summary:
DetailsSection should hide header "options" when collapsed.

The current behavior is mixed, and not controlled by DetailsSection. In some cases options are hidden:
   - Computed Styles panel: "Show All" checkbox
   - Visual Styles panel: "Add Style Rule" button
   - Node panel: Event Listeners "Grouping Method" button

and in other, they are always shown:
   - Debugger sidebar: Pause Reason go-to arrow*
   - Debugger sidebar: "Add XHR Breakpoint" button
   - Probes
   - Watch Expressions

*This is the only case where an exception makes sense to me, since the command doesn't modify the contents of the DetailsSection.
Comment 1 Matt Baker 2017-03-23 15:53:34 PDT 
Created attachment 305234 [details]
Patch
Comment 2 Matt Baker 2017-03-23 15:55:15 PDT 
This change came about after noticing that adding an XHR Breakpoint while the section is collapsed is confusing. Initially I considered expanding the section if a breakpoint is added by the user clicking the "+" button, but decided against it.
Comment 3 WebKit Commit Bot 2017-04-03 15:07:50 PDT 
Comment on attachment 305234 [details]
Patch

Clearing flags on attachment: 305234

Committed r214843: <http://trac.webkit.org/changeset/214843>
Comment 4 WebKit Commit Bot 2017-04-03 15:07:51 PDT 
All reviewed patches have been landed.  Closing bug.