RESOLVED FIXED170029
Web Inspector: DetailsSection should hide header "options" when collapsed 
https://bugs.webkit.org/show_bug.cgi?id=170029
Summary Web Inspector: DetailsSection should hide header "options" when collapsed
Matt Baker
Reported 2017-03-23 15:43:10 PDT
Summary: DetailsSection should hide header "options" when collapsed. The current behavior is mixed, and not controlled by DetailsSection. In some cases options are hidden: - Computed Styles panel: "Show All" checkbox - Visual Styles panel: "Add Style Rule" button - Node panel: Event Listeners "Grouping Method" button and in other, they are always shown: - Debugger sidebar: Pause Reason go-to arrow* - Debugger sidebar: "Add XHR Breakpoint" button - Probes - Watch Expressions *This is the only case where an exception makes sense to me, since the command doesn't modify the contents of the DetailsSection.
Attachments
Patch (11.16 KB, patch)
2017-03-23 15:53 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2017-03-23 15:53:34 PDT
Created attachment 305234 [details] Patch
Matt Baker
Comment 2 2017-03-23 15:55:15 PDT
This change came about after noticing that adding an XHR Breakpoint while the section is collapsed is confusing. Initially I considered expanding the section if a breakpoint is added by the user clicking the "+" button, but decided against it.
WebKit Commit Bot
Comment 3 2017-04-03 15:07:50 PDT
Comment on attachment 305234 [details] Patch Clearing flags on attachment: 305234 Committed r214843: <http://trac.webkit.org/changeset/214843>
WebKit Commit Bot
Comment 4 2017-04-03 15:07:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.