WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
170027
Consider changing MachineThreads::m_registeredThreads to be a linked list of WTFThreadData.
https://bugs.webkit.org/show_bug.cgi?id=170027
Summary
Consider changing MachineThreads::m_registeredThreads to be a linked list of ...
Mark Lam
Reported
2017-03-23 15:07:32 PDT
Currently, MachineThreads instantiates MachineThreads::Thread (which is just a linked list node) that points to MachineThreads::ThreadData (a thread specific record that basically copies the content of WTFThreadData i.e. the stack bounds, and adds a few other things). In order to instantiate the MachineThreads::ThreadData, the code needs to consult (and thereby create) the WTFThreadData instance anyway. If we can lower PlatformThread to the WTF layer (and unify it with whatever representation of a thread id we have there e.g. that which is returned by currentThread()), then we can add that to WTFThreadData. I think it is also fine to add the other platform specific MachineThreads::ThreadData fields to WTFThreadData as well. Note: a side detail, we used to copy the stack bounds base and end. Instead, we can change MachineStackMarker.cpp to use StackBounds::contains() instead to check the stack bounds.
Attachments
Add attachment
proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1
2018-04-01 12:27:16 PDT
MachineThreads are converted to WTF::ThreadGroup.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug