Bug 170023 – Web Inspector: Web Socket Document Icon

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Give Web Sockets a Document Image instead of the default empty document image.

Images needed would be Web Socket variants of:

    DocumentGeneric.png
    [e-mail]
    DocumentGenericLarge.png
    [e-mail]

[Matt Baker]

A quick search for "Web Sockets logo" shows a plug-like icon that is fairly widespread. Maybe some variant on this?

[Joseph Pecoraro]

Created attachment 305609 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 305610 [details]
[IMAGE] Icons @1x

[Matt Baker]

I like the up/down arrows, but think they should be thinner to be consistent with other icons.

[Matt Baker]

We should also use a neutral color. Green implies something about the state of the socket (to me at least).

[Devin Rousso]

This is kinda a NIT, but are we intentionally not having the little corner fold like for the HTML/CSS/JS/Document/Image icons?

[Joseph Pecoraro]

(In reply to Devin Rousso from comment #6)
> This is kinda a NIT, but are we intentionally not having the little corner
> fold like for the HTML/CSS/JS/Document/Image icons?

I noticed that but then came to like this change. Unlike other resources this is not a File resource. It is a Connection resource. The corner fold indicates this is a Text/File-like resource. No-fold indicates it is not, which I think makes sense for a Web Socket connection.

[Matt Baker]

(In reply to Joseph Pecoraro from comment #7)
> (In reply to Devin Rousso from comment #6)
> > This is kinda a NIT, but are we intentionally not having the little corner
> > fold like for the HTML/CSS/JS/Document/Image icons?
> 
> I noticed that but then came to like this change. Unlike other resources
> this is not a File resource. It is a Connection resource. The corner fold
> indicates this is a Text/File-like resource. No-fold indicates it is not,
> which I think makes sense for a Web Socket connection.

Are there other resources that fall into this category? If so we should consider updating those icons too.

[Joseph Pecoraro]

Created attachment 305643 [details]
[PATCH] Proposed Fix (Purple)

[Joseph Pecoraro]

Created attachment 305644 [details]
[IMAGE] Icons @1x (Purple)

[Joseph Pecoraro]

> Are there other resources that fall into this category? If so we should
> consider updating those icons too.

Not that I know of. This is the first of its kind.

Workers were kind of close, but they are created with a single Script, so we have WorkerScript images which is like DocumentScript.png with extra flair.

[Joseph Pecoraro]

Comment on attachment 305643 [details]
[PATCH] Proposed Fix (Purple)

Jon is making one with slightly thinner icons (for the small @1x).

[Joseph Pecoraro]

Created attachment 310547 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 310548 [details]
[IMAGE] Icons @1x (Purple)

[Matt Baker]

Comment on attachment 310547 [details]
[PATCH] Proposed Fix

r=me. I like the square corner.

[WebKit Commit Bot]

Comment on attachment 310547 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 310547

Committed r217067: <http://trac.webkit.org/changeset/217067>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.