RESOLVED FIXED 170012
[GTK] Please add po/Makevars
https://bugs.webkit.org/show_bug.cgi?id=170012
Summary [GTK] Please add po/Makevars
Piotr Drąg
Reported 2017-03-23 11:04:26 PDT
Damned-lies doesn’t support CMake, which causes bugs like <https://bugzilla.gnome.org/show_bug.cgi?id=780458>. Adding a po/Makevars file to WebKitGTK+ would easily work around that problem. You could use <https://git.gnome.org/browse/epiphany/tree/po/Makevars> after adjusting it for WebKitGTK+ (mainly XGETTEXT_OPTIONS).
Attachments
Makevars for WebKitGTK+ (3.49 KB, text/plain)
2017-04-24 09:45 PDT, Piotr Drąg
no flags
Makevars for WebKitGTK+ (3.48 KB, text/plain)
2017-04-24 09:52 PDT, Piotr Drąg
no flags
[GTK] Fix extraction of translator comments (1.98 KB, patch)
2017-04-24 17:35 PDT, Piotr Drąg
mcatanzaro: review-
mcatanzaro: commit-queue-
[GTK] Add po/Makevars (5.10 KB, patch)
2017-04-24 17:35 PDT, Piotr Drąg
no flags
Piotr Drąg
Comment 1 2017-04-24 09:45:34 PDT
Created attachment 307984 [details] Makevars for WebKitGTK+ I was able to generate a POT file that looks correct with this Makevars file in po/.
Piotr Drąg
Comment 2 2017-04-24 09:52:14 PDT
Created attachment 307985 [details] Makevars for WebKitGTK+ I changed the Bugzilla link to HTTPS and fixed extraction of translator comments. They don’t start with “TRANSLATORS:”, so po/CMakeLists.txt needs to be corrected as well.
Carlos Garcia Campos
Comment 3 2017-04-24 10:18:36 PDT
Even if this makefile is only for damned lies, I think it would be better, if possible, to actually use it from the cmake. Mainly because if we change the cmake file, we will for sure forget about this makefile.
Piotr Drąg
Comment 4 2017-04-24 10:33:57 PDT
Maybe you could put a comment in CMakeLists.txt to remind your future self to also update Makevars? :) Damned Lies doesn’t support CMake and it’s very unlikely that it will ever do (if no one steps up and contributes it).
Michael Catanzaro
Comment 5 2017-04-24 11:42:53 PDT
A slightly-related problem is that I get the impression that only a few translations ever manage to migrate from damned-lies to WebKit. Maybe we should be syncing the translations all at once every six months, instead of expecting each translation teams to file new bugs all the time.
Piotr Drąg
Comment 6 2017-04-24 16:52:11 PDT
I agree that reporting a bug is too high of a barrier for translators, and a better solution would be very helpful. We need to fix the statistics first, though.
Piotr Drąg
Comment 7 2017-04-24 17:35:05 PDT
Created attachment 308027 [details] [GTK] Fix extraction of translator comments Removes “TRANSLATORS:” header from po/CMakeLists.txt, as it’s not used and might block extraction of translator comments.
Piotr Drąg
Comment 8 2017-04-24 17:35:51 PDT
Created attachment 308028 [details] [GTK] Add po/Makevars Adds po/Makevars, so we can switch https://l10n.gnome.org/module/webkit/ from intltool to pure gettext and get WEB_UI_STRING* strings extracted.
Michael Catanzaro
Comment 9 2017-04-24 18:43:55 PDT
Comment on attachment 308027 [details] [GTK] Fix extraction of translator comments Looks good, but please file a separate bug for this. Believe it or not, our tools can't handle two patches in the same bug. Thanks.
Michael Catanzaro
Comment 10 2017-04-24 18:47:15 PDT
Carlos, do you want to review the Makevars patch?
Carlos Garcia Campos
Comment 11 2017-04-25 00:11:44 PDT
Comment on attachment 308028 [details] [GTK] Add po/Makevars Ok. Thanks!
WebKit Commit Bot
Comment 12 2017-04-25 00:41:10 PDT
Comment on attachment 308028 [details] [GTK] Add po/Makevars Clearing flags on attachment: 308028 Committed r215725: <http://trac.webkit.org/changeset/215725>
WebKit Commit Bot
Comment 13 2017-04-25 00:41:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.