Bug 170012 – [GTK] Please add po/Makevars

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Piotr Drąg]

Damned-lies doesn’t support CMake, which causes bugs like <https://bugzilla.gnome.org/show_bug.cgi?id=780458>. Adding a po/Makevars file to WebKitGTK+ would easily work around that problem. You could use <https://git.gnome.org/browse/epiphany/tree/po/Makevars> after adjusting it for WebKitGTK+ (mainly XGETTEXT_OPTIONS).

[Piotr Drąg]

Created attachment 307984 [details]
Makevars for WebKitGTK+

I was able to generate a POT file that looks correct with this Makevars file in po/.

[Piotr Drąg]

Created attachment 307985 [details]
Makevars for WebKitGTK+

I changed the Bugzilla link to HTTPS and fixed extraction of translator comments. They don’t start with “TRANSLATORS:”, so po/CMakeLists.txt needs to be corrected as well.

[Carlos Garcia Campos]

Even if this makefile is only for damned lies, I think it would be better, if possible, to actually use it from the cmake. Mainly because if we change the cmake file, we will for sure forget about this makefile.

[Piotr Drąg]

Maybe you could put a comment in CMakeLists.txt to remind your future self to also update Makevars? :)

Damned Lies doesn’t support CMake and it’s very unlikely that it will ever do (if no one steps up and contributes it).

[Michael Catanzaro]

A slightly-related problem is that I get the impression that only a few translations ever manage to migrate from damned-lies to WebKit. Maybe we should be syncing the translations all at once every six months, instead of expecting each translation teams to file new bugs all the time.

[Piotr Drąg]

I agree that reporting a bug is too high of a barrier for translators, and a better solution would be very helpful. We need to fix the statistics first, though.

[Piotr Drąg]

Created attachment 308027 [details]
[GTK] Fix extraction of translator comments

Removes “TRANSLATORS:” header from po/CMakeLists.txt, as it’s not used and might block extraction of translator comments.

[Piotr Drąg]

Created attachment 308028 [details]
[GTK] Add po/Makevars

Adds po/Makevars, so we can switch https://l10n.gnome.org/module/webkit/ from intltool to pure gettext and get WEB_UI_STRING* strings extracted.

[Michael Catanzaro]

Comment on attachment 308027 [details]
[GTK] Fix extraction of translator comments

Looks good, but please file a separate bug for this. Believe it or not, our tools can't handle two patches in the same bug. Thanks.

[Michael Catanzaro]

Carlos, do you want to review the Makevars patch?

[Carlos Garcia Campos]

Comment on attachment 308028 [details]
[GTK] Add po/Makevars

Ok. Thanks!

[WebKit Commit Bot]

Comment on attachment 308028 [details]
[GTK] Add po/Makevars

Clearing flags on attachment: 308028

Committed r215725: <http://trac.webkit.org/changeset/215725>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.