Bug 169987 - NeverDestroyed<MediaQueryEvaluator> must explicitly construct with a String
Summary: NeverDestroyed<MediaQueryEvaluator> must explicitly construct with a String
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 169245
  Show dependency tree / graph
 
Reported: 2017-03-22 18:52 PDT by Dean Jackson
Modified: 2017-03-23 11:26 PDT (History)
1 user (show)

See Also:

Attachments
Patch (2.20 KB, patch)
2017-03-22 18:57 PDT, Dean Jackson 		achristensen: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2017-03-22 18:52:24 PDT 
CSSDefaultStyleSheets creates a static MediaQueryEvaluator, but thanks to the template magic of NeverDestroyed, it was converting the char* argument into a bool, and calling the wrong constructor.
Comment 1 Dean Jackson 2017-03-22 18:53:04 PDT 
<rdar://problem/31211087>
Comment 2 Dean Jackson 2017-03-22 18:57:04 PDT 
Created attachment 305152 [details]
Patch
Comment 3 Dean Jackson 2017-03-23 11:19:12 PDT 
Committed r214305: <http://trac.webkit.org/changeset/214305>