RESOLVED INVALID 169953
Some webkit-patch commands don't work with new bugzilla version 
https://bugs.webkit.org/show_bug.cgi?id=169953
Summary Some webkit-patch commands don't work with new bugzilla version
Carlos Garcia Campos
Reported 2017-03-22 01:58:53 PDT
I guess we are failing to parse users or something like that: $ webkit-patch apply-attachment --local-commit 305002 Updating working directory Updating OpenSource Current branch master is up to date. Logging in as cgarcia igalia.com... Fetching: https://bugs.webkit.org/attachment.cgi?id=305002&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=169915&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 305002 from bug 169915. Warning, attachment 305002 [details] on bug 169915 has invalid reviewer (mcatanzaro) $ webkit-patch land -g HEAD 169915 Logging in as cgarcia igalia.com... Fetching: https://bugs.webkit.org/show_bug.cgi?id=169915&ctype=xml&excludefield=attachmentdata Warning, attachment 305002 [details] on bug 169915 has invalid reviewer (mcatanzaro) No reviewed patches on bug 169915, cannot infer reviewer. Failed to guess reviewer from bug 169915 and --reviewer= not provided. Not updating ChangeLogs with reviewer. Committed r214243: <http://trac.webkit.org/changeset/214243> Updating bug 169915 Closing bug 169915 as fixed Traceback (most recent call last): File "/home/cgarcia/src/git/gnome/WebKit/Tools/Scripts/webkit-patch", line 84, in <module> main() File "/home/cgarcia/src/git/gnome/WebKit/Tools/Scripts/webkit-patch", line 79, in main WebKitPatch(os.path.abspath(__file__)).main() File "/home/cgarcia/src/git/gnome/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/home/cgarcia/src/git/gnome/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/home/cgarcia/src/git/gnome/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/home/cgarcia/src/git/gnome/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors self._run(tool, options, state) File "/home/cgarcia/src/git/gnome/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run step(tool, options).run(state) File "/home/cgarcia/src/git/gnome/WebKit/Tools/Scripts/webkitpy/tool/steps/closebugforlanddiff.py", line 54, in run self._tool.bugs.close_bug_as_fixed(bug_id, comment_text) File "/home/cgarcia/src/git/gnome/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 823, in close_bug_as_fixed self.browser['comment'] = comment_text File "/home/cgarcia/src/git/gnome/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_form.py", line 2780, in __setitem__ control = self.find_control(name) File "/home/cgarcia/src/git/gnome/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_form.py", line 3101, in find_control return self._find_control(name, type, kind, id, label, predicate, nr) File "/home/cgarcia/src/git/gnome/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_form.py", line 3185, in _find_control raise ControlNotFoundError("no control matching "+description) webkitpy.thirdparty.autoinstalled.mechanize._form.ControlNotFoundError: no control matching name 'comment' No comment was added to the bug and it wasn't closed either.
Attachments
Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-03-22 04:32:27 PDT
I've just realized that my pass was indeed too simple, so it's probably the issue mentioned in webkit-dev. I was confused because it didn't show any error about logging in, and it complained about the reviewer instead. Anyway, I'm closing this, I'll reopen if it still fails the next time I try to land something. Sorry for the noise.
Note You need to log in before you can comment on or make changes to this bug.