Bug 169926 - Fix Apache::SizeLimit unshared size limit in mod_perl.pl for bugs.webkit.org
Summary: Fix Apache::SizeLimit unshared size limit in mod_perl.pl for bugs.webkit.org
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-21 14:38 PDT by David Kilzer (:ddkilzer)
Modified: 2022-01-31 08:37 PST (History)
6 users (show)

See Also:


Attachments
Patch (1.46 KB, patch)
2017-03-21 14:47 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch (1.46 KB, patch)
2017-03-21 14:49 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch (1.46 KB, patch)
2017-03-21 15:13 PDT, David Kilzer (:ddkilzer)
bfulgham: review+
Details | Formatted Diff | Diff
Patch for landing (1.46 KB, patch)
2017-03-21 15:44 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2017-03-21 14:38:21 PDT
After updating to Bugzilla 5.0.3, the syntax for the Apache::SizeLimit module changed:

-Apache2::SizeLimit->set_max_unshared_size(700_000);
+$Apache2::SizeLimit::MAX_UNSHARED_SIZE = 800000;

This is to track that change, and to test fixing "webkit-patch upload" for the new Bugzilla.
Comment 1 David Kilzer (:ddkilzer) 2017-03-21 14:47:11 PDT
Created attachment 305029 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2017-03-21 14:48:57 PDT
Let's try uploading again, this time as a security bug.
Comment 3 David Kilzer (:ddkilzer) 2017-03-21 14:49:20 PDT
Created attachment 305031 [details]
Patch
Comment 4 David Kilzer (:ddkilzer) 2017-03-21 15:11:40 PDT
Mucking with the title.
Comment 5 David Kilzer (:ddkilzer) 2017-03-21 15:13:33 PDT
Created attachment 305032 [details]
Patch
Comment 6 Brent Fulgham 2017-03-21 15:15:25 PDT
Comment on attachment 305032 [details]
Patch

Seems reasonable. Wish we had EWS coverage for this, but at least we'll notice if we break anything pretty quickly!
Comment 7 David Kilzer (:ddkilzer) 2017-03-21 15:44:35 PDT
Created attachment 305039 [details]
Patch for landing
Comment 8 Radar WebKit Bug Importer 2017-03-23 09:36:52 PDT
<rdar://problem/31221133>