Generate IOSurface backed CVPixelBuffers.
Created attachment 305027 [details] Proposed patch.
Comment on attachment 305027 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=305027&action=review > Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.h:56 > + RetainPtr<CVPixelBufferRef> pixelBufferFromCGImage(CGImageRef); Keep it const and make m_bufferPool mutable? > Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.h:60 > + bool applySize(const IntSize&) override; Use final.
Created attachment 305035 [details] Patch for landing.
Comment on attachment 305035 [details] Patch for landing. Rejecting attachment 305035 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 305035, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: fs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 214253 = da3f5293315f5782d6a2a6abfd0b26e35e202cbc r214254 = 6679bded9e36e6fc6215a0654356302f85106dc7 r214255 = 420029cd551f8817a0ccd2a5c2c8e5c383d5ce99 r214256 = b7e4e1d9db541c7b59a415ff7275e27f5d6578aa Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/3388345
Comment on attachment 305035 [details] Patch for landing. Set cq+ again to see if the bots are feeling better.
Attachment 305035 [details] did not pass style-queue: ERROR: Source/WebCore/platform/cocoa/CoreVideoSoftLink.cpp:42: Missing space after , [whitespace/comma] [3] ERROR: Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:116: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:120: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 305035 [details] Patch for landing. Clearing flags on attachment: 305035 Committed r214302: <http://trac.webkit.org/changeset/214302>
Bump (to import this into Radar)
<rdar://problem/31220631>