Bug 169891 – Prevent new navigations from onbeforeunload handler

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Daniel Bates]

We should not allow navigation initiated from an onberforeunload handler.

[Radar WebKit Bug Importer]

<rdar://problem/31155736>

[Daniel Bates]

Created attachment 304947 [details]
Patch and layout test

[Simon Fraser (smfr)]

Comment on attachment 304947 [details]
Patch and layout test

View in context: https://bugs.webkit.org/attachment.cgi?id=304947&action=review

> Source/WebCore/ChangeLog:3
> +        onbeforeunload handler may start new navigation

Would be nice to phrase this more actively: "onbeforeunload handler may start new navigation but should not be able to", or, better, "Prevent new navigations from onbeforeunload handler"

[Daniel Bates]

Comment on attachment 304947 [details]
Patch and layout test

View in context: https://bugs.webkit.org/attachment.cgi?id=304947&action=review

> LayoutTests/fast/events/before-unload-forbidden-navigation.html:15
> +var didFireOnBeforeLoad = false;

Will rename to didFireOnbeforeunloadEvent before landing. I am open to suggestions.

[Daniel Bates]

Created attachment 304948 [details]
Patch and layout test

Updated ChangeLog to reflect updated bug title. Also renamed the variable didFireOnBeforeLoad to didFireBeforeUnloadEvent in the included test.

[Daniel Bates]

Comment on attachment 304948 [details]
Patch and layout test

Clearing flags on attachment: 304948

Committed r214194: <http://trac.webkit.org/changeset/214194>

[Daniel Bates]

All reviewed patches have been landed.  Closing bug.

[Brent Fulgham]

*** Bug 169833 has been marked as a duplicate of this bug. ***

[Lucas Forschler]

Mass move bugs into the DOM component.