Bug 169890 - WebAssembly: can mprotect ever fail?
Summary: WebAssembly: can mprotect ever fail?
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 159775
  Show dependency tree / graph
 
Reported: 2017-03-20 13:59 PDT by JF Bastien
Modified: 2017-04-19 16:21 PDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description JF Bastien 2017-03-20 13:59:34 PDT 
WasmMemory uses mprotect and tries to handle its failure. I'm not sure it should ever fail according to the manpage for MacOS. Linux seems to allow failure if the kernel runs out of memory for its internal data structures, which seems *really* bad.

In both cases I suspect we should just assert out.
Comment 1 JF Bastien 2017-04-19 16:21:34 PDT 
Fixed in other patches.