Bug 169888 - Charts page show an inconsistent list of revisions for Git and Subversion
Summary: Charts page show an inconsistent list of revisions for Git and Subversion
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-20 13:54 PDT by Ryosuke Niwa
Modified: 2017-03-20 18:19 PDT (History)
3 users (show)

See Also:


Attachments
Patch (123.55 KB, patch)
2017-03-20 15:44 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Patch for landing (90.08 KB, patch)
2017-03-20 17:11 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Patch for landing (90.41 KB, patch)
2017-03-20 17:20 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Patch for landing (90.41 KB, patch)
2017-03-20 17:25 PDT, Ryosuke Niwa
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-03-20 13:54:15 PDT
When using Git, we end up showing the last data point's revision
instead of all revisions after the last data point.
Comment 1 Ryosuke Niwa 2017-03-20 15:44:23 PDT
Created attachment 304960 [details]
Patch
Comment 2 Ryosuke Niwa 2017-03-20 17:11:08 PDT
Created attachment 304970 [details]
Patch for landing
Comment 3 WebKit Commit Bot 2017-03-20 17:12:40 PDT
Comment on attachment 304970 [details]
Patch for landing

Rejecting attachment 304970 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 304970, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Websites/perf.webkit.org/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/3372326
Comment 4 Ryosuke Niwa 2017-03-20 17:20:16 PDT
Created attachment 304973 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2017-03-20 17:21:38 PDT
Comment on attachment 304973 [details]
Patch for landing

Rejecting attachment 304973 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 304973, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
/perf.webkit.org/public/v3/models/data-model.js
patching file Websites/perf.webkit.org/public/v3/remote.js
patching file Websites/perf.webkit.org/server-tests/api-commits-tests.js
patching file Websites/perf.webkit.org/server-tests/api-commits.js
rm 'Websites/perf.webkit.org/server-tests/api-commits.js'
patching file Websites/perf.webkit.org/unit-tests/commit-log-tests.js

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3372444
Comment 6 Ryosuke Niwa 2017-03-20 17:25:52 PDT
Created attachment 304976 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2017-03-20 17:28:10 PDT
Comment on attachment 304976 [details]
Patch for landing

Rejecting attachment 304976 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 304976, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
/perf.webkit.org/public/v3/models/data-model.js
patching file Websites/perf.webkit.org/public/v3/remote.js
patching file Websites/perf.webkit.org/server-tests/api-commits-tests.js
patching file Websites/perf.webkit.org/server-tests/api-commits.js
rm 'Websites/perf.webkit.org/server-tests/api-commits.js'
patching file Websites/perf.webkit.org/unit-tests/commit-log-tests.js

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3372483
Comment 8 Ryosuke Niwa 2017-03-20 18:19:47 PDT
Committed r214202: <http://trac.webkit.org/changeset/214202>