Bug 169867 - B3::LowerToAir incorrectly selects BitXor(AtomicStrongCAS(...), $1)
Summary: B3::LowerToAir incorrectly selects BitXor(AtomicStrongCAS(...), $1)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-19 16:14 PDT by Filip Pizlo
Modified: 2017-04-04 15:38 PDT (History)
5 users (show)

See Also:


Attachments
the patch (4.29 KB, patch)
2017-04-04 15:06 PDT, Filip Pizlo
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-03-19 16:14:58 PDT
It thinks that this is just like NotEqual(AtomicStrongCAS(@exp, ...), @exp).  It's not.  We need to teach it to only look for AtomicWeakCAS in that pattern, not any AtomicCAS.
Comment 1 Filip Pizlo 2017-04-04 15:06:37 PDT
Created attachment 306210 [details]
the patch
Comment 2 Filip Pizlo 2017-04-04 15:38:14 PDT
Landed in https://trac.webkit.org/changeset/214908/webkit