Uncaught Exceptions: - TypeError: null is not an object (evaluating 'this.dataGrid._popover') (at ResourceTimelineDataGridNode.js:424:82) ? @ ResourceTimelineDataGridNode.js:424:82 * STEPS TO REPRODUCE 1. In Web Inspector, open Network tab 2. Open http://webkit.org/ 3. Hover over the timing bar at the right side of the content view to show the timing information popover. 4. Quickly click on the Clear Network Items icon.
<rdar://problem/31132652>
Created attachment 304879 [details] Patch
Comment on attachment 304879 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304879&action=review r=me > Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js:430 > + let dismissPopover = () => { > + if (this.dataGrid) > + this.dataGrid._popover.dismiss(); > + }; > + > + this.dataGrid._dismissPopoverTimeout = setTimeout(dismissPopover, WebInspector.ResourceTimelineDataGridNode.DelayedPopoverDismissalTimeout); Style: We normally inline arrow functions used in only one place: this.dataGrid._dismissPopoverTimeout = setTimeout(() => { if (this.dataGrid) this.dataGrid._popover.dismiss(); }, WebInspector.ResourceTimelineDataGridNode.DelayedPopoverDismissalTimeout);
Created attachment 304974 [details] Patch
Comment on attachment 304974 [details] Patch Clearing flags on attachment: 304974 Committed r214199: <http://trac.webkit.org/changeset/214199>
All reviewed patches have been landed. Closing bug.