Bug 169850 - Web Inspector: Pseudo-class markers overlap DOM breakpoints and disclosure triangle
Summary: Web Inspector: Pseudo-class markers overlap DOM breakpoints and disclosure tr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-18 13:38 PDT by Matt Baker
Modified: 2017-03-20 17:14 PDT (History)
3 users (show)

See Also:

Attachments
[Image] Pseudo-element marker overlap (125.83 KB, image/png)
2017-03-18 13:38 PDT, Matt Baker 		no flags Details
[Image] DOM breakpoint overlap (300.85 KB, image/png)
2017-03-18 13:41 PDT, Matt Baker 		no flags Details
Patch (3.51 KB, patch)
2017-03-18 13:58 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
[Image] w/ patch applied (196.12 KB, image/png)
2017-03-18 14:20 PDT, Matt Baker 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2017-03-18 13:38:40 PDT 
Created attachment 304874 [details]
[Image] Pseudo-element marker overlap

Summary:
Pseudo-element markers overlap DOM breakpoints and disclosure triangle. Specifically the <html> tag's disclosure triangle.

See screenshot.
Comment 1 Radar WebKit Bug Importer 2017-03-18 13:39:24 PDT 
<rdar://problem/31132335>
Comment 2 Matt Baker 2017-03-18 13:41:22 PDT 
Created attachment 304875 [details]
[Image] DOM breakpoint overlap

The breakpoint is disabled so the pseudo-element marker stands out more.
Comment 3 Radar WebKit Bug Importer 2017-03-18 13:56:49 PDT 
<rdar://problem/31132400>
Comment 4 Matt Baker 2017-03-18 13:58:35 PDT 
Created attachment 304876 [details]
Patch
Comment 5 Matt Baker 2017-03-18 14:20:08 PDT 
Created attachment 304877 [details]
[Image] w/ patch applied
Comment 6 Joseph Pecoraro 2017-03-20 16:45:56 PDT 
Comment on attachment 304876 [details]
Patch

r=me
Comment 7 WebKit Commit Bot 2017-03-20 17:14:41 PDT 
Comment on attachment 304876 [details]
Patch

Clearing flags on attachment: 304876

Committed r214196: <http://trac.webkit.org/changeset/214196>
Comment 8 WebKit Commit Bot 2017-03-20 17:14:46 PDT 
All reviewed patches have been landed.  Closing bug.