RESOLVED FIXED 169845
TextIndicator should support a mode where selection rects are used to size the snapshot 
https://bugs.webkit.org/show_bug.cgi?id=169845
Summary TextIndicator should support a mode where selection rects are used to size th...
Wenson Hsieh
Reported 2017-03-17 22:03:53 PDT
<rdar://problem/31127818>
Attachments
Patch (6.12 KB, patch)
2017-03-17 22:12 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Hook into new flag in WK2 (8.43 KB, patch)
2017-03-17 22:28 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2017-03-17 22:12:03 PDT
Created attachment 304861 [details] Patch
Wenson Hsieh
Comment 2 2017-03-17 22:28:59 PDT
Created attachment 304863 [details] Hook into new flag in WK2
Wenson Hsieh
Comment 3 2017-03-20 10:03:47 PDT
Comment on attachment 304863 [details] Hook into new flag in WK2 Thanks Beth!
WebKit Commit Bot
Comment 4 2017-03-20 10:32:52 PDT
Comment on attachment 304863 [details] Hook into new flag in WK2 Clearing flags on attachment: 304863 Committed r214174: <http://trac.webkit.org/changeset/214174>
WebKit Commit Bot
Comment 5 2017-03-20 10:32:58 PDT
All reviewed patches have been landed. Closing bug.
Tim Horton
Comment 6 2017-03-22 13:14:34 PDT
Comment on attachment 304863 [details] Hook into new flag in WK2 View in context: https://bugs.webkit.org/attachment.cgi?id=304863&action=review > Source/WebCore/page/TextIndicator.h:89 > + // Currently, this is only supported on iOS. This is a little weird, I think, because the text rects *are* the selection rects on Mac, right?
Wenson Hsieh
Comment 7 2017-03-22 13:17:17 PDT
(In reply to Tim Horton from comment #6) > Comment on attachment 304863 [details] > Hook into new flag in WK2 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=304863&action=review > > > Source/WebCore/page/TextIndicator.h:89 > > + // Currently, this is only supported on iOS. > > This is a little weird, I think, because the text rects *are* the selection > rects on Mac, right? True. This is a bit confusing, since the rects used here specifically refer to those emitted by our selection rect collection heuristic on iOS. I'll make this distinction clear in a followup.
Note You need to log in before you can comment on or make changes to this bug.