Bug 169834 - REGRESSION (r214047): LayoutTest fast/events/pageshow-pagehide-on-back-cached-with-frames.html is a flaky failure
Summary: REGRESSION (r214047): LayoutTest fast/events/pageshow-pagehide-on-back-cached...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on: 169682
Blocks:
  Show dependency tree / graph
 
Reported: 2017-03-17 15:57 PDT by Ryan Haddad
Modified: 2017-03-23 12:57 PDT (History)
2 users (show)

See Also:

Attachments
Layout test (4.07 KB, patch)
2017-03-21 12:36 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Layout test (8.00 KB, patch)
2017-03-21 13:41 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2017-03-17 15:57:40 PDT 
LayoutTest fast/events/pageshow-pagehide-on-back-cached-with-frames.html is a flaky failure

https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK1%20(Tests)/r214123%20(39)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fevents%2Fpageshow-pagehide-on-back-cached-with-frames.html

--- /Volumes/Data/slave/elcapitan-release-tests-wk1/build/layout-test-results/fast/events/pageshow-pagehide-on-back-cached-with-frames-expected.txt
+++ /Volumes/Data/slave/elcapitan-release-tests-wk1/build/layout-test-results/fast/events/pageshow-pagehide-on-back-cached-with-frames-actual.txt
@@ -1,12 +1,12 @@
 CONSOLE MESSAGE: line 21: ***Top level frame being parsed for the initial page load***
+CONSOLE MESSAGE: line 21: Subsubframe2 window.onload
+CONSOLE MESSAGE: line 21: Subsubframe2 window.onpageshow, target = [object HTMLDocument], persisted = false
+CONSOLE MESSAGE: line 21: Subframe2 window.onload
+CONSOLE MESSAGE: line 21: Subframe2 window.onpageshow, target = [object HTMLDocument], persisted = false
 CONSOLE MESSAGE: line 21: Subsubframe window.onload
 CONSOLE MESSAGE: line 21: Subsubframe window.onpageshow, target = [object HTMLDocument], persisted = false
 CONSOLE MESSAGE: line 21: Subframe window.onload
 CONSOLE MESSAGE: line 21: Subframe window.onpageshow, target = [object HTMLDocument], persisted = false
-CONSOLE MESSAGE: line 21: Subsubframe2 window.onload
-CONSOLE MESSAGE: line 21: Subsubframe2 window.onpageshow, target = [object HTMLDocument], persisted = false
-CONSOLE MESSAGE: line 21: Subframe2 window.onload
-CONSOLE MESSAGE: line 21: Subframe2 window.onpageshow, target = [object HTMLDocument], persisted = false
 CONSOLE MESSAGE: line 21: Main frame window.onload
 CONSOLE MESSAGE: line 21: Main frame window.onpageshow, target = [object HTMLDocument], persisted = false
 CONSOLE MESSAGE: line 21: ***Navigating top-level frame to a page that will immediately navigate back to this one***
Comment 1 Ryan Haddad 2017-03-17 15:58:25 PDT 
Seems to have started after https://trac.webkit.org/changeset/214047
Comment 2 Alexey Proskuryakov 2017-03-20 20:50:46 PDT 
Daniel, could you please take a look?
Comment 3 Daniel Bates 2017-03-20 20:58:44 PDT 
(In reply to comment #2)
> Daniel, could you please take a look?

I will look into this tomorrow.
Comment 4 Daniel Bates 2017-03-21 12:36:06 PDT 
Created attachment 305011 [details]
Layout test
Comment 5 Daniel Bates 2017-03-21 13:41:43 PDT 
Created attachment 305022 [details]
Layout test

Actually ensure we load the subframes in tree order.
Comment 6 Daniel Bates 2017-03-23 12:56:49 PDT 
Comment on attachment 305022 [details]
Layout test

Clearing flags on attachment: 305022

Committed r214311: <http://trac.webkit.org/changeset/214311>
Comment 7 Daniel Bates 2017-03-23 12:56:52 PDT 
All reviewed patches have been landed.  Closing bug.