Bug 169830 - Disable per-region boxes for multicolumn
Summary: Disable per-region boxes for multicolumn
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-17 13:24 PDT by Dave Hyatt
Modified: 2017-03-17 14:59 PDT (History)
0 users

See Also:


Attachments
Patch (6.48 KB, patch)
2017-03-17 13:26 PDT, Dave Hyatt
zalan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2017-03-17 13:24:05 PDT
Disable per-region boxes for multicolumn
Comment 1 Dave Hyatt 2017-03-17 13:26:32 PDT
Created attachment 304816 [details]
Patch
Comment 2 zalan 2017-03-17 13:36:37 PDT
Comment on attachment 304816 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304816&action=review

> Source/WebCore/rendering/RenderBox.cpp:2732
> +    if (isRenderFlowThread() || !flowThread || !is<RenderNamedFlowThread>(flowThread) || !canHaveBoxInfoInRegion() || flowThread->style().writingMode() != style().writingMode())

!is<RenderNamedFlowThread>(flowThread) covers !flowThread too
-> if (isRenderFlowThread() || !is<RenderNamedFlowThread>(flowThread) || ...
Comment 3 Dave Hyatt 2017-03-17 14:59:45 PDT
Landed in r214126.