169802 – Use completion handlers instead of return values for sending websocket data

Bug 169802 - Use completion handlers instead of return values for sending websocket data

Summary: Use completion handlers instead of return values for sending websocket data

Attachments
Patch (8.89 KB, patch) 2017-03-16 18:15 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Patch (10.85 KB, patch) 2017-03-16 21:42 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Patch (11.02 KB, patch) 2017-03-17 00:18 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Fix GTK+ build (11.32 KB, patch) 2017-03-17 01:31 PDT, Carlos Garcia Campos	cgarcia: review+	Details \| Formatted Diff \| Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alex Christensen 2017-03-16 18:15:07 PDT

Use completion handlers instead of return values for sending websocket data

Comment 1 Alex Christensen 2017-03-16 18:15:51 PDT

Created attachment 304731 [details]
Patch

Comment 2 Alex Christensen 2017-03-16 21:42:34 PDT

Created attachment 304752 [details]
Patch

Comment 3 Alex Christensen 2017-03-16 22:39:40 PDT

I don't understand why GTK fails to build.  Could someone look at it?

Comment 4 Alex Christensen 2017-03-17 00:18:03 PDT

Created attachment 304761 [details]
Patch

Comment 5 Carlos Garcia Campos 2017-03-17 01:31:20 PDT

Created attachment 304766 [details]
Fix GTK+ build

Function.h needs to be included in WebSocketServerConnection.cpp

Comment 6 Carlos Garcia Campos 2017-03-17 02:46:36 PDT

Comment on attachment 304766 [details]
Fix GTK+ build

r=me

Comment 7 Alex Christensen 2017-03-17 08:57:36 PDT

http://trac.webkit.org/r214106

Comment 8 Alex Christensen 2017-03-17 08:57:54 PDT

Thanks Carlos!