Bug 169795 – Initial letter does not paginate properly.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dave Hyatt]

Initial letter does not paginate properly.

[Dave Hyatt]

Created attachment 304711 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 304711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304711&action=review

> Source/WebCore/rendering/FloatingObjects.h:98
>      RootInlineBox* m_originatingLine;

Might as well convert this to { nullptr }

> Source/WebCore/rendering/RenderBlockFlow.cpp:1886
> +            // Increase our logical height to ensure that lines all get pushed along with the
> +            // letter.

Comment can go one one line.

> Source/WebCore/rendering/RenderBlockFlow.cpp:2263
> +            LayoutRect floatBox(offsetFromRootBlock.width(), offsetFromRootBlock.height(),                 floatingObject.renderer().width(), floatingObject.renderer().height());

Weird huge space.

[Dave Hyatt]

Created attachment 304714 [details]
Patch

[Build Bot]

Comment on attachment 304714 [details]
Patch

Attachment 304714 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3343917

New failing tests:
fast/regions/overflow/overflow-in-variable-width-regions-inline-bt.html
imported/blink/fast/multicol/vertical-rl/float-break.html
imported/blink/fast/multicol/vertical-rl/float-edge.html
fast/regions/overflow/overflow-in-variable-width-regions-inline-rl.html
fast/writing-mode/vertical-float-margin.html
imported/blink/fast/multicol/vertical-rl/float-content-break.html
fast/regions/selection/selecting-text-ignoring-region-vert-rl.html
fast/regions/selection/selecting-text-ignoring-region-horiz-bt.html

[Build Bot]

Created attachment 304722 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 304714 [details]
Patch

Attachment 304714 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3344025

New failing tests:
fast/regions/overflow/overflow-in-variable-width-regions-inline-bt.html
imported/blink/fast/multicol/vertical-rl/float-break.html
imported/blink/fast/multicol/vertical-rl/float-edge.html
fast/regions/overflow/overflow-in-variable-width-regions-inline-rl.html
fast/writing-mode/vertical-float-margin.html
imported/blink/fast/multicol/vertical-rl/float-big-line.html
imported/blink/fast/multicol/vertical-rl/float-content-break.html
fast/regions/selection/selecting-text-ignoring-region-vert-rl.html
fast/regions/selection/selecting-text-ignoring-region-horiz-bt.html

[Build Bot]

Created attachment 304723 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 304714 [details]
Patch

Attachment 304714 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3344060

New failing tests:
fast/regions/overflow/overflow-in-variable-width-regions-inline-bt.html
imported/blink/fast/multicol/vertical-rl/float-break.html
imported/blink/fast/multicol/vertical-rl/float-edge.html
fast/regions/overflow/overflow-in-variable-width-regions-inline-rl.html
fast/writing-mode/vertical-float-margin.html
imported/blink/fast/multicol/vertical-rl/float-big-line.html
imported/blink/fast/multicol/vertical-rl/float-content-break.html
fast/regions/selection/selecting-text-ignoring-region-vert-rl.html
fast/regions/selection/selecting-text-ignoring-region-horiz-bt.html

[Build Bot]

Created attachment 304726 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 304714 [details]
Patch

Attachment 304714 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3344127

New failing tests:
fast/css-generated-content/initial-letter-pagination-raised.html
imported/blink/fast/multicol/vertical-rl/float-edge.html
fast/writing-mode/vertical-float-margin.html
fast/css-generated-content/initial-letter-pagination-sunken.html
imported/blink/fast/multicol/vertical-rl/float-break.html
imported/blink/fast/multicol/vertical-rl/float-big-line.html
imported/blink/fast/multicol/vertical-rl/float-content-break.html
fast/regions/selection/selecting-text-ignoring-region-vert-rl.html

[Build Bot]

Created attachment 304727 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Dave Hyatt]

Created attachment 304778 [details]
Patch

[WebKit Commit Bot]

Attachment 304778 [details] did not pass style-queue:


ERROR: LayoutTests/platform/ios-simulator/TestExpectations:2919:  Path does not exist.  [test/expectations] [5]
ERROR: LayoutTests/platform/ios-simulator/TestExpectations:2920:  Path does not exist.  [test/expectations] [5]
Total errors found: 2 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Created attachment 304779 [details]
Patch

[Build Bot]

Comment on attachment 304779 [details]
Patch

Attachment 304779 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3350024

New failing tests:
fast/block/lineboxcontain/block-with-ideographs.xhtml
fast/css-generated-content/initial-letter-pagination-sunken-rl.html
fast/multicol/tall-image-behavior-rl.html
fast/multicol/tall-image-behavior-lr.html

[Build Bot]

Created attachment 304784 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 304779 [details]
Patch

Attachment 304779 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3350039

New failing tests:
fast/block/lineboxcontain/block-with-ideographs.xhtml
fast/css-generated-content/initial-letter-pagination-sunken-rl.html
fast/multicol/tall-image-behavior-rl.html
fast/css-generated-content/initial-letter-pagination-raised-rl.html
fast/multicol/tall-image-behavior-lr.html

[Build Bot]

Created attachment 304785 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 304779 [details]
Patch

Attachment 304779 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3350033

New failing tests:
fast/block/lineboxcontain/block-with-ideographs.xhtml
fast/css-generated-content/initial-letter-pagination-sunken-rl.html
fast/multicol/tall-image-behavior-rl.html
fast/multicol/tall-image-behavior-lr.html

[Build Bot]

Created attachment 304786 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 304779 [details]
Patch

Attachment 304779 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3350090

New failing tests:
fast/multicol/tall-image-behavior-rl.html
fast/multicol/tall-image-behavior-lr.html

[Build Bot]

Created attachment 304788 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Dave Hyatt]

Created attachment 304794 [details]
Patch

[Dave Hyatt]

Landed in r214110.