Bug 169793 - buildbot: run-webkit-tests should display test failures and run exceptions differently
Summary: buildbot: run-webkit-tests should display test failures and run exceptions di...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-16 15:30 PDT by Jonathan Bedard
Modified: 2017-03-23 14:45 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.83 KB, patch)
2017-03-16 15:37 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2017-03-16 15:30:10 PDT
Right now, failing to run LayoutTests because of a simulator or test harness bug is treated the same way a single test failure is.  Simulator bugs and test harness bugs, as well as any exception thrown and not managed in run-webkit-tests should cause an exception in build-bot.
Comment 1 Jonathan Bedard 2017-03-16 15:37:49 PDT
Created attachment 304707 [details]
Patch
Comment 2 Alexey Proskuryakov 2017-03-17 11:23:42 PDT
Is this happening on bots? Do you have an example link?
Comment 3 Jonathan Bedard 2017-03-17 12:35:00 PDT
(In reply to comment #2)
> Is this happening on bots? Do you have an example link?

Currently, the WebKit bots are in a stable state, so we are not experiencing these issues at the moment.
Comment 4 WebKit Commit Bot 2017-03-20 10:11:06 PDT
Comment on attachment 304707 [details]
Patch

Clearing flags on attachment: 304707

Committed r214172: <http://trac.webkit.org/changeset/214172>
Comment 5 WebKit Commit Bot 2017-03-20 10:11:12 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Carlos Alberto Lopez Perez 2017-03-23 14:45:21 PDT
Committed r214318: <http://trac.webkit.org/changeset/214318>