Bug 169779 - Web Inspector: REGRESSION (r213691): Saving DOM breakpoints broken after refactoring
Summary: Web Inspector: REGRESSION (r213691): Saving DOM breakpoints broken after refa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-16 13:32 PDT by Matt Baker
Modified: 2017-03-16 17:23 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.68 KB, patch)
2017-03-16 13:35 PDT, Matt Baker
no flags Details | Formatted Diff | Diff
Patch (1.77 KB, patch)
2017-03-16 15:32 PDT, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2017-03-16 13:32:25 PDT
DOMDebuggerManager.prototype._saveBreakpoints should be "_saveDOMBreakpoints".
Comment 1 Matt Baker 2017-03-16 13:35:34 PDT
Created attachment 304684 [details]
Patch
Comment 2 Joseph Pecoraro 2017-03-16 14:39:41 PDT
Comment on attachment 304684 [details]
Patch

This isn't exactly a typo, its a real bug fix. I'm actually surprised no tests cause this, I'd expect any test using addDOMBreakpoint to trigger an uncaught exception and show up in test results.
Comment 3 Matt Baker 2017-03-16 15:32:27 PDT
Created attachment 304705 [details]
Patch
Comment 4 WebKit Commit Bot 2017-03-16 17:23:48 PDT
Comment on attachment 304705 [details]
Patch

Clearing flags on attachment: 304705

Committed r214083: <http://trac.webkit.org/changeset/214083>
Comment 5 WebKit Commit Bot 2017-03-16 17:23:54 PDT
All reviewed patches have been landed.  Closing bug.