Bug 169772 - Clean up WKContentExtension API
Summary: Clean up WKContentExtension API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-16 11:50 PDT by Alex Christensen
Modified: 2017-03-16 12:06 PDT (History)
0 users

See Also:

Attachments
Patch (18.49 KB, patch)
2017-03-16 11:53 PDT, Alex Christensen 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-03-16 11:50:31 PDT 
Clean up WKContentExtension API
Comment 1 Alex Christensen 2017-03-16 11:53:25 PDT 
Created attachment 304662 [details]
Patch
Comment 2 Geoffrey Garen 2017-03-16 12:03:40 PDT 
Comment on attachment 304662 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304662&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKContentExtension.h:34
> +@property (nonatomic, readonly, copy) NSString *identifier;

If we're going to use this string in the file system, we need to give it name like "fileSystemIdentifier", in order to communicate to clients the restrictions on what can go in this string.
Comment 3 Alex Christensen 2017-03-16 12:06:58 PDT 
http://trac.webkit.org/r214061