Bug 169766 – Web Inspector: RTL: filter mode icon in Debugger sidebar is misaligned

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

Created attachment 304654 [details]
[RTL] screenshot

Oops.

[Devin Rousso]

Created attachment 304671 [details]
Patch

[Devin Rousso]

Created attachment 304672 [details]
[Image] After Patch is applied

[Matt Baker]

Comment on attachment 304671 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304671&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/FilterBar.css:42
> +    padding: 0 0 3px;

I don't think .navigation-bar > .item inherits any padding (turning of this rule in Inspector shows computed padding zero). Could just be:

padding-bottom: 3px;

[Devin Rousso]

Comment on attachment 304671 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304671&action=review

>> Source/WebInspectorUI/UserInterface/Views/FilterBar.css:42
>> +    padding: 0 0 3px;
> 
> I don't think .navigation-bar > .item inherits any padding (turning of this rule in Inspector shows computed padding zero). Could just be:
> 
> padding-bottom: 3px;

It currently doesn't inherit, but I would prefer to keep it this way.  It lessens the likelihood of a future change causing an issue via inheritance.

[WebKit Commit Bot]

Comment on attachment 304671 [details]
Patch

Clearing flags on attachment: 304671

Committed r214066: <http://trac.webkit.org/changeset/214066>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.