Bug 169766 - Web Inspector: RTL: filter mode icon in Debugger sidebar is misaligned
Summary: Web Inspector: RTL: filter mode icon in Debugger sidebar is misaligned
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-16 10:35 PDT by BJ Burg
Modified: 2017-03-16 13:53 PDT (History)
3 users (show)

See Also:

Attachments
[RTL] screenshot (14.89 KB, image/png)
2017-03-16 10:35 PDT, BJ Burg 		no flags Details
Patch (1.63 KB, patch)
2017-03-16 12:23 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
[Image] After Patch is applied (10.00 KB, image/png)
2017-03-16 12:23 PDT, Devin Rousso 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2017-03-16 10:35:21 PDT 
Created attachment 304654 [details]
[RTL] screenshot

Oops.
Comment 1 Devin Rousso 2017-03-16 12:23:22 PDT 
Created attachment 304671 [details]
Patch
Comment 2 Devin Rousso 2017-03-16 12:23:35 PDT 
Created attachment 304672 [details]
[Image] After Patch is applied
Comment 3 Matt Baker 2017-03-16 13:09:37 PDT 
Comment on attachment 304671 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304671&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/FilterBar.css:42
> +    padding: 0 0 3px;

I don't think .navigation-bar > .item inherits any padding (turning of this rule in Inspector shows computed padding zero). Could just be:

padding-bottom: 3px;
Comment 4 Devin Rousso 2017-03-16 13:25:10 PDT 
Comment on attachment 304671 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304671&action=review

>> Source/WebInspectorUI/UserInterface/Views/FilterBar.css:42
>> +    padding: 0 0 3px;
> 
> I don't think .navigation-bar > .item inherits any padding (turning of this rule in Inspector shows computed padding zero). Could just be:
> 
> padding-bottom: 3px;

It currently doesn't inherit, but I would prefer to keep it this way.  It lessens the likelihood of a future change causing an issue via inheritance.
Comment 5 WebKit Commit Bot 2017-03-16 13:53:50 PDT 
Comment on attachment 304671 [details]
Patch

Clearing flags on attachment: 304671

Committed r214066: <http://trac.webkit.org/changeset/214066>
Comment 6 WebKit Commit Bot 2017-03-16 13:53:53 PDT 
All reviewed patches have been landed.  Closing bug.