WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
169763
Web Inspector: RTL: selected frame indicator is not positioned correctly
https://bugs.webkit.org/show_bug.cgi?id=169763
Summary
Web Inspector: RTL: selected frame indicator is not positioned correctly
Blaze Burg
Reported
2017-03-16 10:29:54 PDT
Created
attachment 304649
[details]
[RTL] screenshot Looks like it's flipped or something.
Attachments
[RTL] screenshot
(172.40 KB, image/png)
2017-03-16 10:29 PDT
,
Blaze Burg
no flags
Details
Patch
(7.79 KB, patch)
2017-03-16 12:53 PDT
,
Devin Rousso
mattbaker
: review+
Details
Formatted Diff
Diff
[Image] After Patch is applied
(36.70 KB, image/png)
2017-03-16 12:54 PDT
,
Devin Rousso
no flags
Details
Patch
(9.07 KB, patch)
2017-03-16 13:37 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Devin Rousso
Comment 1
2017-03-16 12:53:54 PDT
Created
attachment 304678
[details]
Patch
Devin Rousso
Comment 2
2017-03-16 12:54:11 PDT
Created
attachment 304679
[details]
[Image] After Patch is applied
Matt Baker
Comment 3
2017-03-16 13:26:13 PDT
Comment on
attachment 304678
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=304678&action=review
> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css:47 > + transform: translateX(-1px);
Nit: This should probably be a variable (in the scope of .timeline-ruler), but a name might be tricky. `--timeline-ruler-divider-marker-horizontal-offset`?
Devin Rousso
Comment 4
2017-03-16 13:37:08 PDT
Created
attachment 304685
[details]
Patch
WebKit Commit Bot
Comment 5
2017-03-16 16:11:57 PDT
Comment on
attachment 304685
[details]
Patch Clearing flags on attachment: 304685 Committed
r214076
: <
http://trac.webkit.org/changeset/214076
>
WebKit Commit Bot
Comment 6
2017-03-16 16:12:05 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug