Bug 169763 - Web Inspector: RTL: selected frame indicator is not positioned correctly
Summary: Web Inspector: RTL: selected frame indicator is not positioned correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-16 10:29 PDT by Brian Burg
Modified: 2017-03-16 16:12 PDT (History)
3 users (show)

See Also:


Attachments
[RTL] screenshot (172.40 KB, image/png)
2017-03-16 10:29 PDT, Brian Burg
no flags Details
Patch (7.79 KB, patch)
2017-03-16 12:53 PDT, Devin Rousso
mattbaker: review+
Details | Formatted Diff | Diff
[Image] After Patch is applied (36.70 KB, image/png)
2017-03-16 12:54 PDT, Devin Rousso
no flags Details
Patch (9.07 KB, patch)
2017-03-16 13:37 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2017-03-16 10:29:54 PDT
Created attachment 304649 [details]
[RTL] screenshot

Looks like it's flipped or something.
Comment 1 Devin Rousso 2017-03-16 12:53:54 PDT
Created attachment 304678 [details]
Patch
Comment 2 Devin Rousso 2017-03-16 12:54:11 PDT
Created attachment 304679 [details]
[Image] After Patch is applied
Comment 3 Matt Baker 2017-03-16 13:26:13 PDT
Comment on attachment 304678 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304678&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css:47
> +    transform: translateX(-1px);

Nit: This should probably be a variable (in the scope of .timeline-ruler), but a name might be tricky. `--timeline-ruler-divider-marker-horizontal-offset`?
Comment 4 Devin Rousso 2017-03-16 13:37:08 PDT
Created attachment 304685 [details]
Patch
Comment 5 WebKit Commit Bot 2017-03-16 16:11:57 PDT
Comment on attachment 304685 [details]
Patch

Clearing flags on attachment: 304685

Committed r214076: <http://trac.webkit.org/changeset/214076>
Comment 6 WebKit Commit Bot 2017-03-16 16:12:05 PDT
All reviewed patches have been landed.  Closing bug.