Bug 169745 - [UNIX] Implement currentSearchLocaleID() and currentTextBreakLocaleID()
Summary: [UNIX] Implement currentSearchLocaleID() and currentTextBreakLocaleID()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2017-03-16 04:22 PDT by Carlos Garcia Campos
Modified: 2017-03-16 04:55 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.54 KB, patch)
2017-03-16 04:24 PDT, Carlos Garcia Campos
utatane.tea: review+
Details | Formatted Diff | Diff
Patch for landing (4.70 KB, patch)
2017-03-16 04:49 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-03-16 04:22:11 PDT
They are currently unimplemented and with a FIXME to use the system locale instead of default values. I think we can use the result of setlocale here directly
Comment 1 Carlos Garcia Campos 2017-03-16 04:24:13 PDT
Created attachment 304631 [details]
Patch
Comment 2 Yusuke Suzuki 2017-03-16 04:38:49 PDT
Comment on attachment 304631 [details]
Patch

r=me. Can we use it too in JSCOnly port? Maybe,

if (WIN32)
    ...
else ()
    APPEND(... unix things)
endif ()

And I think we can drop text/jsconly thing.
Comment 3 Carlos Garcia Campos 2017-03-16 04:49:37 PDT
Created attachment 304633 [details]
Patch for landing

Including changes for JSCOnly
Comment 4 Yusuke Suzuki 2017-03-16 04:52:05 PDT
Comment on attachment 304633 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=304633&action=review

> Source/WTF/wtf/PlatformJSCOnly.cmake:6
>      text/jsconly/TextBreakIteratorInternalICUJSCOnly.cpp

We need to drop this line too.
Comment 5 Carlos Garcia Campos 2017-03-16 04:54:04 PDT
(In reply to comment #4)
> Comment on attachment 304633 [details]
> Patch for landing
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=304633&action=review
> 
> > Source/WTF/wtf/PlatformJSCOnly.cmake:6
> >      text/jsconly/TextBreakIteratorInternalICUJSCOnly.cpp
> 
> We need to drop this line too.

Right, I've just realized, thanks!
Comment 6 Carlos Garcia Campos 2017-03-16 04:55:26 PDT
Committed r214036: <http://trac.webkit.org/changeset/214036>