Bug 169745 – [UNIX] Implement currentSearchLocaleID() and currentTextBreakLocaleID()

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[Carlos Garcia Campos]

They are currently unimplemented and with a FIXME to use the system locale instead of default values. I think we can use the result of setlocale here directly

[Carlos Garcia Campos]

Created attachment 304631 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 304631 [details]
Patch

r=me. Can we use it too in JSCOnly port? Maybe,

if (WIN32)
    ...
else ()
    APPEND(... unix things)
endif ()

And I think we can drop text/jsconly thing.

[Carlos Garcia Campos]

Created attachment 304633 [details]
Patch for landing

Including changes for JSCOnly

[Yusuke Suzuki]

Comment on attachment 304633 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=304633&action=review

> Source/WTF/wtf/PlatformJSCOnly.cmake:6
>      text/jsconly/TextBreakIteratorInternalICUJSCOnly.cpp

We need to drop this line too.

[Carlos Garcia Campos]

(In reply to comment #4)
> Comment on attachment 304633 [details]
> Patch for landing
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=304633&action=review
> 
> > Source/WTF/wtf/PlatformJSCOnly.cmake:6
> >      text/jsconly/TextBreakIteratorInternalICUJSCOnly.cpp
> 
> We need to drop this line too.

Right, I've just realized, thanks!

[Carlos Garcia Campos]

Committed r214036: <http://trac.webkit.org/changeset/214036>