Bug 169743 - [JSC] Generate TemplateObjects at linking time
Summary: [JSC] Generate TemplateObjects at linking time
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-16 03:02 PDT by Yusuke Suzuki
Modified: 2017-04-05 00:09 PDT (History)
5 users (show)

See Also:

Attachments
Patch (16.42 KB, patch)
2017-03-16 03:06 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (18.74 KB, patch)
2017-03-16 12:30 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (18.63 KB, patch)
2017-03-16 12:34 PDT, Yusuke Suzuki 		keith_miller: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-03-16 03:02:04 PDT 
[JSC] Generate TemplateObjects at linking time
Comment 1 Yusuke Suzuki 2017-03-16 03:06:27 PDT 
Created attachment 304627 [details]
Patch
Comment 2 Yusuke Suzuki 2017-03-16 12:30:10 PDT 
Created attachment 304673 [details]
Patch
Comment 3 Yusuke Suzuki 2017-03-16 12:34:41 PDT 
Created attachment 304674 [details]
Patch
Comment 4 Yusuke Suzuki 2017-04-04 10:35:59 PDT 
Ping?
Comment 5 Keith Miller 2017-04-04 10:57:53 PDT 
Comment on attachment 304674 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304674&action=review

r=me with a question.

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:932
> +    scope.release();

Why do you need the manually release the scope here?
Comment 6 Yusuke Suzuki 2017-04-05 00:06:48 PDT 
Comment on attachment 304674 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304674&action=review

>> Source/JavaScriptCore/bytecode/CodeBlock.cpp:932
>> +    scope.release();
> 
> Why do you need the manually release the scope here?

Oops, it's not neccessary. Thanks.
Comment 7 Yusuke Suzuki 2017-04-05 00:09:48 PDT 
Committed r214931: <http://trac.webkit.org/changeset/214931>