Bug information (such as if the bug is resolved) is applied to links in comments (usually via strikethroughs) so long as the URL matches the pattern https://bugs.webkit.org/show_bug.cgi?id=# This functionality should be extended to include bug short links, namely https://webkit.org/b/#
Adding webkit.org/b would be reasonable. Note that "bug XXX" turns into a link too (and so does "bug XXX comment YYY"). That's the preferred form for it I think.
Created attachment 304574 [details] Patch I am very inexperienced with Perl, but this is what I was able to figure out. Not sure if it's correct, as I don't know how to test changes to any WebKit site. Any feedback (both for the change and future debugging/testing tips) would be greatly appreciated.
Comment on attachment 304574 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304574&action=review > Websites/bugs.webkit.org/Bugzilla/Template.pm:213 > + $text =~ s~\b((\Qhttps?://\E)?\Qwebkit.org/b/\E([0-9]+)(\#c([0-9]+))?)\b I think the (\Qhttps?://\E) is wrong. \Q...\E eliminates special character matching, so I would expect this to match the literal "https?://" instead of what it looks like you want which is either "http://" or "https://": http://www.perlmonks.org/bare/?node_id=468052 You probably want: s~\b((https?://)?\Qwebkit.org/b/\E([0-9]+)(\#c([0-9]+))?)\b~ In this case, $1 is still the entire URL, $3 is still the bug#, and $5 is still the comment#. Should be able to test this in JavaScript as such: /\b((https?:\/\/)?webkit\.org\/b\/([0-9]+)(\#c([0-9]+))?)\b/
Created attachment 304598 [details] Patch
Comment on attachment 304598 [details] Patch This looks good to me. We should rebase this. Sync up with Alexey to ask if there is anything you should do before landing, otherwise this looks good.
Yes, please don't land before e-mail discussion is complete.
Created attachment 311047 [details] Patch
Comment on attachment 311047 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311047&action=review > Websites/bugs.webkit.org/Bugzilla/Template.pm:214 > + $text =~ s~\b((https?://)?\Qwebkit.org/b/\E([0-9]+)(\#c([0-9]+))?)\b > + ~($things[$count++] = get_bug_link($3, $1, { comment_num => $5, user => $user })) && > + ("\x{FDD2}" . ($count-1) . "\x{FDD3}") > + ~egox; Perhaps this should be wrapped in: #if WEBKIT_CHANGES ... #endif I think ddkilzer knows best here. Otherwise this looks good to me!
Comment on attachment 311047 [details] Patch Attachment 311047 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3808275 New failing tests: http/tests/cache/cancel-during-revalidation-succeeded.html fast/css/target-fragment-match.html
Created attachment 311145 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Comment on attachment 311047 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311047&action=review r=me with adding of a WEBKIT_CHANGES comment. >> Websites/bugs.webkit.org/Bugzilla/Template.pm:214 >> + ~egox; > > Perhaps this should be wrapped in: > > #if WEBKIT_CHANGES > ... > #endif > > I think ddkilzer knows best here. Otherwise this looks good to me! Yes, please add a comment, even if it's just this before the new code: # WEBKIT_CHANGES This type of comment makes a full-tree diff to upstream lets future mergers know this was an intentional change rather than an accident or a merge artifact. Note the "#" in Perl is a comment character so the use of #if/#endif is just gratuitous decoration. :)
Created attachment 311242 [details] Patch
Comment on attachment 311242 [details] Patch Clearing flags on attachment: 311242 Committed r217504: <http://trac.webkit.org/changeset/217504>
All reviewed patches have been landed. Closing bug.
<rdar://problem/32479872>