Bug 169699 - Don't use an optional for didReceiveSocketStreamData's length
Summary: Don't use an optional for didReceiveSocketStreamData's length
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-15 14:58 PDT by Alex Christensen
Modified: 2017-04-05 18:56 PDT (History)
2 users (show)

See Also:


Attachments
Patch (6.21 KB, patch)
2017-03-15 14:59 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews117 for mac-elcapitan (1.57 MB, application/zip)
2017-03-15 15:40 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews100 for mac-elcapitan (614.91 KB, application/zip)
2017-03-15 15:46 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (945.24 KB, application/zip)
2017-03-15 15:54 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (19.15 MB, application/zip)
2017-03-15 16:17 PDT, Build Bot
no flags Details
Patch (6.84 KB, patch)
2017-03-16 13:54 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (6.93 KB, patch)
2017-03-16 13:57 PDT, Alex Christensen
beidson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-03-15 14:58:36 PDT
Don't use an optional for didReceiveSocketStreamData's length
Comment 1 Alex Christensen 2017-03-15 14:59:21 PDT
Created attachment 304555 [details]
Patch
Comment 2 Alex Christensen 2017-03-15 15:07:33 PDT
Comment on attachment 304555 [details]
Patch

nope
Comment 3 Build Bot 2017-03-15 15:39:59 PDT
Comment on attachment 304555 [details]
Patch

Attachment 304555 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3333169

Number of test failures exceeded the failure limit.
Comment 4 Build Bot 2017-03-15 15:40:01 PDT
Created attachment 304562 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 5 Build Bot 2017-03-15 15:46:52 PDT
Comment on attachment 304555 [details]
Patch

Attachment 304555 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3333271

Number of test failures exceeded the failure limit.
Comment 6 Build Bot 2017-03-15 15:46:54 PDT
Created attachment 304568 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 7 Build Bot 2017-03-15 15:54:34 PDT
Comment on attachment 304555 [details]
Patch

Attachment 304555 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3333285

Number of test failures exceeded the failure limit.
Comment 8 Build Bot 2017-03-15 15:54:37 PDT
Created attachment 304571 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 9 Build Bot 2017-03-15 16:17:20 PDT
Comment on attachment 304555 [details]
Patch

Attachment 304555 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3333327

Number of test failures exceeded the failure limit.
Comment 10 Build Bot 2017-03-15 16:17:24 PDT
Created attachment 304576 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 11 Alex Christensen 2017-03-16 13:54:27 PDT
Created attachment 304686 [details]
Patch
Comment 12 Alex Christensen 2017-03-16 13:57:31 PDT
Created attachment 304687 [details]
Patch
Comment 13 Brady Eidson 2017-03-16 14:35:31 PDT
Comment on attachment 304687 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304687&action=review

> Source/WebCore/ChangeLog:7
> +

"No new tests (no behavior change)."
Comment 14 Alex Christensen 2017-04-05 18:56:18 PDT
http://trac.webkit.org/r214073