Bug 169697 - Web Inspector: Refactoring: remove DebuggerTreeElement class
Summary: Web Inspector: Refactoring: remove DebuggerTreeElement class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords:
Depends on:
Blocks: 169702
  Show dependency treegraph
 
Reported: 2017-03-15 14:37 PDT by Matt Baker
Modified: 2017-03-16 13:50 PDT (History)
2 users (show)

See Also:


Attachments
Patch (8.21 KB, patch)
2017-03-15 14:38 PDT, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2017-03-15 14:37:04 PDT
This class only provided a wrapper property `debuggerObject` around TreeElement.prototype.representedObject, which DebuggerSidebarPanel tested for during tree element sorting. We should just test for TreeElement.prototype.representedObject.sourceCodeLocation.
Comment 1 Matt Baker 2017-03-15 14:38:28 PDT
Created attachment 304552 [details]
Patch
Comment 2 Devin Rousso 2017-03-16 13:04:14 PDT
Comment on attachment 304552 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2017-03-16 13:50:40 PDT
Comment on attachment 304552 [details]
Patch

Clearing flags on attachment: 304552

Committed r214064: <http://trac.webkit.org/changeset/214064>
Comment 4 WebKit Commit Bot 2017-03-16 13:50:43 PDT
All reviewed patches have been landed.  Closing bug.