RESOLVED FIXED 169695
In-browser and node.js implementations of RemoteAPI should share some code 
https://bugs.webkit.org/show_bug.cgi?id=169695
Summary In-browser and node.js implementations of RemoteAPI should share some code
Ryosuke Niwa
Reported 2017-03-15 13:58:50 PDT
Right now, tools/remote.js and public/v3/remote.js duplicate a lot of code for checking the status, etc... Share the common code between the two.
Attachments
Cleanup (30.48 KB, patch)
2017-03-15 14:12 PDT, Ryosuke Niwa 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-03-15 14:12:33 PDT
Created attachment 304544 [details] Cleanup
Ryosuke Niwa
Comment 2 2017-03-15 14:13:24 PDT
This refactoring also makes some aspects of RemoteAPI, e.g. status check, testable.
Antti Koivisto
Comment 3 2017-03-15 14:14:36 PDT
Comment on attachment 304544 [details] Cleanup rs=me
Ryosuke Niwa
Comment 4 2017-03-15 14:58:38 PDT
Thanks for the review!
Ryosuke Niwa
Comment 5 2017-03-15 14:59:15 PDT
Committed r214008: <http://trac.webkit.org/changeset/214008>
Note You need to log in before you can comment on or make changes to this bug.