Bug 169695 - In-browser and node.js implementations of RemoteAPI should share some code
Summary: In-browser and node.js implementations of RemoteAPI should share some code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-15 13:58 PDT by Ryosuke Niwa
Modified: 2017-03-15 14:59 PDT (History)
2 users (show)

See Also:


Attachments
Cleanup (30.48 KB, patch)
2017-03-15 14:12 PDT, Ryosuke Niwa
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-03-15 13:58:50 PDT
Right now, tools/remote.js and public/v3/remote.js duplicate a lot of code for checking the status, etc...
Share the common code between the two.
Comment 1 Ryosuke Niwa 2017-03-15 14:12:33 PDT
Created attachment 304544 [details]
Cleanup
Comment 2 Ryosuke Niwa 2017-03-15 14:13:24 PDT
This refactoring also makes some aspects of RemoteAPI, e.g. status check, testable.
Comment 3 Antti Koivisto 2017-03-15 14:14:36 PDT
Comment on attachment 304544 [details]
Cleanup

rs=me
Comment 4 Ryosuke Niwa 2017-03-15 14:58:38 PDT
Thanks for the review!
Comment 5 Ryosuke Niwa 2017-03-15 14:59:15 PDT
Committed r214008: <http://trac.webkit.org/changeset/214008>