Bug 169676 - Fix uninitialized public members in WTF
Summary: Fix uninitialized public members in WTF
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tomas Popela
URL:
Keywords:
Depends on:
Blocks: 104114
  Show dependency tree / graph
 
Reported: 2017-03-15 08:05 PDT by Tomas Popela
Modified: 2017-03-23 07:56 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.34 KB, patch)
2017-03-15 08:07 PDT, Tomas Popela 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Popela 2017-03-15 08:05:16 PDT 
Found by Coverity scan.
Comment 1 Tomas Popela 2017-03-15 08:07:57 PDT 
Created attachment 304500 [details]
Patch
Comment 2 Alexey Proskuryakov 2017-03-15 19:28:31 PDT 
Comment on attachment 304500 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304500&action=review

> Source/WTF/ChangeLog:8
> +        Found by Coverity scan.

Does this fix any bugs?
Comment 3 Tomas Popela 2017-03-16 01:51:48 PDT 
(In reply to comment #2)
> Comment on attachment 304500 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=304500&action=review
> 
> > Source/WTF/ChangeLog:8
> > +        Found by Coverity scan.
> 
> Does this fix any bugs?

No known bugs yet, but only initializes uninitialized members.
Comment 4 Tomas Popela 2017-03-23 02:10:43 PDT 
Comment on attachment 304500 [details]
Patch

Clearing flags on attachment: 304500

Committed r214299: <http://trac.webkit.org/changeset/214299>
Comment 5 Tomas Popela 2017-03-23 02:10:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Darin Adler 2017-03-23 07:56:05 PDT 
While I suppose this is OK, I am not sure why it’s important to initialize data members in code paths where they are never read from.