Bug 169672 – Make it possible to use WEB_UI_STRING macros to mark translatable strings in glib based ports

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Carlos Garcia Campos]

WEB_UI_STRING macros are currently used by Cocoa based ports and Windows port. For other ports it simply returns the given string, but it's not translated. In the GTK+ port we have all translatable strings from LocalizedStrings.cpp copied in LocalizedStringsGtk.cpp to use the glib macros to mark them as translatable. In most of the cases the strings are exactly in the same, in some others (the context menu ones) the string only differs in the mnemonics used by GTK, and only in a few cases the strings are different. We could remove most of that duplication if strings used by WEB_UI_STRING were marked as translatable in glib based ports too.

[Carlos Garcia Campos]

Created attachment 304498 [details]
Patch

[Michael Catanzaro]

Comment on attachment 304498 [details]
Patch

Nice! Let's try it.

[Carlos Garcia Campos]

Committed r214244: <http://trac.webkit.org/changeset/214244>

[Piotr Drąg]

A lot of strings disappeared from the .pot file at https://l10n.gnome.org/module/webkit/ — I just want to make sure that’s intended.

[Carlos Garcia Campos]

(In reply to Piotr Drąg from comment #4)
> A lot of strings disappeared from the .pot file at
> https://l10n.gnome.org/module/webkit/ — I just want to make sure that’s
> intended.

I would expect more, not less. How is that pot file generated? It's not from a webkit build for sure.

[Piotr Drąg]

It’s probably using intltool, but I’m not sure. I’ve files a bug against damned-lies: https://bugzilla.gnome.org/show_bug.cgi?id=780458