Bug 169668 - [Modern Media Controls] Always use six digits to display time when overall media duration is an hour or more
Summary: [Modern Media Controls] Always use six digits to display time when overall me...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-15 02:25 PDT by Antoine Quint
Modified: 2017-03-15 05:42 PDT (History)
2 users (show)

See Also:


Attachments
Patch (15.67 KB, patch)
2017-03-15 02:46 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2017-03-15 02:25:30 PDT
We currently use extra margins around time labels that may eventually show a duration an hour or more so that when that happens, we don't resize everything. But this creates some extra space which is not elegant. We should instead be using six digits at all times when we know the media duration is an hour or more.
Comment 1 Radar WebKit Bug Importer 2017-03-15 02:25:52 PDT
<rdar://problem/31059699>
Comment 2 Antoine Quint 2017-03-15 02:46:01 PDT
Created attachment 304492 [details]
Patch
Comment 3 WebKit Commit Bot 2017-03-15 05:42:41 PDT
Comment on attachment 304492 [details]
Patch

Clearing flags on attachment: 304492

Committed r213980: <http://trac.webkit.org/changeset/213980>
Comment 4 WebKit Commit Bot 2017-03-15 05:42:44 PDT
All reviewed patches have been landed.  Closing bug.