Bug 169667 - URL: protocol setter needs to be more restrictive around file
Summary: URL: protocol setter needs to be more restrictive around file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-15 01:35 PDT by Anne van Kesteren
Modified: 2019-10-22 09:57 PDT (History)
10 users (show)

See Also:

Attachments
Patch (14.26 KB, patch)
2019-10-06 09:16 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (14.26 KB, patch)
2019-10-06 12:13 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (14.17 KB, patch)
2019-10-19 11:42 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (9.23 KB, patch)
2019-10-21 00:32 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (8.20 KB, patch)
2019-10-21 02:23 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (9.47 KB, patch)
2019-10-21 08:43 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (8.21 KB, patch)
2019-10-22 00:09 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anne van Kesteren 2017-03-15 01:35:09 PDT 
See new tests added in https://github.com/w3c/web-platform-tests/pull/5112 and standard changes at https://github.com/whatwg/url/pull/269.
Comment 1 Rob Buis 2019-10-06 09:16:51 PDT 
Created attachment 380298 [details]
Patch
Comment 2 Rob Buis 2019-10-06 12:13:54 PDT 
Created attachment 380302 [details]
Patch
Comment 3 Rob Buis 2019-10-19 11:42:47 PDT 
Created attachment 381374 [details]
Patch
Comment 4 Rob Buis 2019-10-21 00:32:02 PDT 
Created attachment 381406 [details]
Patch
Comment 5 Rob Buis 2019-10-21 02:23:50 PDT 
Created attachment 381410 [details]
Patch
Comment 6 Rob Buis 2019-10-21 08:43:20 PDT 
Created attachment 381413 [details]
Patch
Comment 7 Alex Christensen 2019-10-21 13:35:00 PDT 
Comment on attachment 381413 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381413&action=review

> Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp:154
> +    fprintf(stderr, "InjectedBundle::overrideBoolPreferenceForTestRunner\n");

This looks like debug code that should not be committed.

> Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp:265
> +        fprintf(stderr, "Set CSSTypedOMEnabled\n");

ditto
Comment 8 Rob Buis 2019-10-22 00:09:05 PDT 
Created attachment 381516 [details]
Patch
Comment 9 WebKit Commit Bot 2019-10-22 01:20:41 PDT 
Comment on attachment 381516 [details]
Patch

Clearing flags on attachment: 381516

Committed r251422: <https://trac.webkit.org/changeset/251422>
Comment 10 WebKit Commit Bot 2019-10-22 01:20:43 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2019-10-22 01:21:18 PDT 
<rdar://problem/56492506>
Comment 12 Darin Adler 2019-10-22 09:57:28 PDT 
Seems a little strange to add this restriction at the URL::setProtocol level; I would have expected it to be a level higher.