Bug 169665 - [TexMap] Add missing class member initializations
Summary: [TexMap] Add missing class member initializations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks: 104114
  Show dependency tree / graph
 
Reported: 2017-03-15 01:31 PDT by Zan Dobersek
Modified: 2017-04-03 00:56 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.95 KB, patch)
2017-03-15 01:33 PDT, Zan Dobersek 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2017-03-15 01:31:17 PDT 
[TexMap] Add missing class member initializations
Comment 1 Zan Dobersek 2017-03-15 01:33:11 PDT 
Created attachment 304489 [details]
Patch
Comment 2 Michael Catanzaro 2017-03-15 08:50:58 PDT 
Comment on attachment 304489 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304489&action=review

> Source/WebCore/platform/graphics/texmap/BitmapTexturePool.h:62
> +        double m_lastUsedTime { 0 };

So I know it doesn't matter... but that's an int. I like to write 0.0.

> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:235
> +    double m_lastAnimationStartTime { 0 };

Ditto.
Comment 3 Zan Dobersek 2017-03-15 11:02:12 PDT 
Committed r213989: <http://trac.webkit.org/changeset/213989>
Comment 4 Konstantin Tokarev 2017-04-03 00:56:34 PDT 
(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 304489 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=304489&action=review
> 
> > Source/WebCore/platform/graphics/texmap/BitmapTexturePool.h:62
> > +        double m_lastUsedTime { 0 };
> 
> So I know it doesn't matter... but that's an int. I like to write 0.0.

Coding style says we should write "0"

https://webkit.org/code-style-guidelines/#floating-point-literals

> 
> > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:235
> > +    double m_lastAnimationStartTime { 0 };
> 
> Ditto.