RESOLVED FIXED 169656
FTL should support global and eval code 
https://bugs.webkit.org/show_bug.cgi?id=169656
Summary FTL should support global and eval code
Filip Pizlo
Reported 2017-03-14 21:10:35 PDT
Patch forthcoiming.
Attachments
possible patch (20.40 KB, patch)
2017-03-14 21:11 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2017-03-14 21:11:36 PDT
Created attachment 304468 [details] possible patch STill testing it
WebKit Commit Bot
Comment 2 2017-03-15 15:52:16 PDT
Attachment 304468 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/FTLLink.cpp:137: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/ftl/FTLLink.cpp:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2017-03-15 18:01:17 PDT
Comment on attachment 304468 [details] possible patch r=me
Saam Barati
Comment 4 2017-03-15 20:11:39 PDT
Comment on attachment 304468 [details] possible patch View in context: https://bugs.webkit.org/attachment.cgi?id=304468&action=review LGTM too > Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp:-397 > - jit.load32(CCallHelpers::payloadFor(CallFrameSlot::argumentCount), GPRInfo::regT2); Was all this code just unneeded?
Filip Pizlo
Comment 5 2017-03-16 08:52:58 PDT
(In reply to comment #4) > Comment on attachment 304468 [details] > possible patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=304468&action=review > > LGTM too > > > Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp:-397 > > - jit.load32(CCallHelpers::payloadFor(CallFrameSlot::argumentCount), GPRInfo::regT2); > > Was all this code just unneeded? Yeah! Crazy!
Filip Pizlo
Comment 6 2017-03-16 14:19:47 PDT
Landed in https://trac.webkit.org/changeset/214069
Note You need to log in before you can comment on or make changes to this bug.