Bug 169651 – Make a base class for WebGL and WebGPU contexts

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dean Jackson]

Make a base class for WebGL and WebGPU contexts

[Dean Jackson]

<rdar://problem/31053489>

[Dean Jackson]

Created attachment 304460 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 304460 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304460&action=review

> Source/WebCore/html/HTMLCanvasElement.cpp:397
> +        static_cast<GPUBasedCanvasRenderingContext*>(m_context.get())->reshape(width(), height());

This should be downcast<>.

> Source/WebCore/html/HTMLCanvasElement.cpp:463
> +        static_cast<GPUBasedCanvasRenderingContext*>(m_context.get())->markLayerComposited();

downcast<>

> Source/WebCore/html/canvas/GPUBasedCanvasRenderingContext.h:48
> +    virtual void reshape(int width, int height) = 0;

Maybe IntSize eventually.

> Source/WebCore/html/canvas/WebGLRenderingContextBase.h:342
> +    void reshape(int width, int height) override;

final?

> Source/WebCore/html/canvas/WebGLRenderingContextBase.h:344
> +    void markLayerComposited() override;

final?

> Source/WebCore/html/canvas/WebGPURenderingContext.h:52
> +    bool isWebGPU() const override { return true; }

final?

> Source/WebCore/html/canvas/WebGPURenderingContext.h:54
> +    void reshape(int width, int height) override;

final?

[Dean Jackson]

Committed r213977: <http://trac.webkit.org/changeset/213977>

[Ryan Haddad]

(In reply to comment #4)
> Committed r213977: <http://trac.webkit.org/changeset/213977>

This change broke the Windows build:
https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/84817

[Ryan Haddad]

Reverted r213977 for reason:

This change broke the Windows build.

Committed r213985: <http://trac.webkit.org/changeset/213985>

[Dean Jackson]

Created attachment 304519 [details]
Patch

[Build Bot]

Comment on attachment 304519 [details]
Patch

Attachment 304519 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3332104

New failing tests:
imported/w3c/web-platform-tests/IndexedDB/fire-success-event-exception.html

[Build Bot]

Created attachment 304535 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Dean Jackson]

Created attachment 304536 [details]
Patch

[Dean Jackson]

Created attachment 304545 [details]
Patch

[Build Bot]

Comment on attachment 304536 [details]
Patch

Attachment 304536 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3332592

New failing tests:
imported/w3c/web-platform-tests/IndexedDB/fire-success-event-exception.html

[Build Bot]

Created attachment 304554 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Dean Jackson]

Created attachment 304557 [details]
Patch

[Dean Jackson]

It helps if you upload the correct patch. #protip

[Dean Jackson]

Committed r214017: <http://trac.webkit.org/changeset/214017>