Bug 169643 - Compiled content extensions should include the JSON source
Summary: Compiled content extensions should include the JSON source
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-14 16:31 PDT by Alex Christensen
Modified: 2017-03-15 10:59 PDT (History)
1 user (show)

See Also:

Attachments
patch (28.40 KB, patch)
2017-03-14 16:37 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (29.48 KB, patch)
2017-03-14 17:17 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (29.47 KB, patch)
2017-03-14 17:31 PDT, Alex Christensen 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-03-14 16:31:32 PDT 
This way we can do things like validation of compiled binaries and automatic migrations from old versions.
Comment 1 Alex Christensen 2017-03-14 16:37:20 PDT 
Created attachment 304441 [details]
patch
Comment 2 WebKit Commit Bot 2017-03-14 16:39:13 PDT 
Attachment 304441 [details] did not pass style-queue:


ERROR: Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
ERROR: Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alex Christensen 2017-03-14 17:17:58 PDT 
Created attachment 304448 [details]
Patch
Comment 4 Alex Christensen 2017-03-14 17:31:30 PDT 
Created attachment 304450 [details]
Patch
Comment 5 Geoffrey Garen 2017-03-15 10:17:50 PDT 
Comment on attachment 304450 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304450&action=review

r=me

> Source/WebKit2/UIProcess/API/Cocoa/WKContentExtensionStore.mm:38
> +    switch (error.value()) {

I think it's better to cast error.value() to API::ContentExtensionStore::Error instead of casting API::ContentExtensionStore::Error to int. That way, the switch can enforce checking for all enumerated values at compile time.
Comment 6 Alex Christensen 2017-03-15 10:59:24 PDT 
http://trac.webkit.org/r213988