Bug 169631 - Simple line layout: Extend webkit-hyphenate-limit-lines to cover subsequent words.
Summary: Simple line layout: Extend webkit-hyphenate-limit-lines to cover subsequent w...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-14 14:43 PDT by zalan
Modified: 2017-03-16 15:14 PDT (History)
7 users (show)

See Also:

Attachments
Patch (15.45 KB, patch)
2017-03-14 14:49 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (15.86 KB, patch)
2017-03-15 18:26 PDT, zalan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-elcapitan (1.07 MB, application/zip)
2017-03-15 19:30 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.01 MB, application/zip)
2017-03-15 19:33 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews117 for mac-elcapitan (1.86 MB, application/zip)
2017-03-15 19:42 PDT, Build Bot 		no flags Details
Patch (21.50 KB, patch)
2017-03-16 14:33 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-03-14 14:43:24 PDT 
Current this property on forced on the current word. 
like:
respon-
sibili-
ties
but not across multiple words on different lines like
foobar foo-
bar fo foo-
bar
Comment 1 zalan 2017-03-14 14:49:59 PDT 
Created attachment 304427 [details]
Patch
Comment 2 zalan 2017-03-15 18:26:09 PDT 
Created attachment 304591 [details]
Patch
Comment 3 Build Bot 2017-03-15 19:30:35 PDT 
Comment on attachment 304591 [details]
Patch

Attachment 304591 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3334827

New failing tests:
fast/text/hyphenate-limit-lines.html
Comment 4 Build Bot 2017-03-15 19:30:40 PDT 
Created attachment 304596 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 5 Build Bot 2017-03-15 19:33:28 PDT 
Comment on attachment 304591 [details]
Patch

Attachment 304591 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3334832

New failing tests:
fast/text/hyphenate-limit-lines.html
Comment 6 Build Bot 2017-03-15 19:33:31 PDT 
Created attachment 304597 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 7 Build Bot 2017-03-15 19:42:02 PDT 
Comment on attachment 304591 [details]
Patch

Attachment 304591 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3334838

New failing tests:
fast/text/hyphenate-limit-lines.html
Comment 8 Build Bot 2017-03-15 19:42:05 PDT 
Created attachment 304599 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 9 zalan 2017-03-16 14:33:05 PDT 
Created attachment 304693 [details]
Patch
Comment 10 WebKit Commit Bot 2017-03-16 15:14:39 PDT 
Comment on attachment 304693 [details]
Patch

Clearing flags on attachment: 304693

Committed r214072: <http://trac.webkit.org/changeset/214072>
Comment 11 WebKit Commit Bot 2017-03-16 15:14:53 PDT 
All reviewed patches have been landed.  Closing bug.