WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
169617
Simple line layout: Adjust hyphenation constrains based on the normal line layout line-breaking logic.
https://bugs.webkit.org/show_bug.cgi?id=169617
Summary
Simple line layout: Adjust hyphenation constrains based on the normal line la...
zalan
Reported
2017-03-14 11:27:24 PDT
There are fractional differences with enlarged font size.
Attachments
Patch
(8.68 KB, patch)
2017-03-14 11:37 PDT
,
zalan
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
zalan
Comment 1
2017-03-14 11:37:38 PDT
Created
attachment 304405
[details]
Patch
Antti Koivisto
Comment 2
2017-03-14 13:26:20 PDT
Comment on
attachment 304405
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=304405&action=review
> Source/WebCore/rendering/line/BreakingContext.h:665 > +inline void tryHyphenating(RenderText& text, const FontCascade& font, const AtomicString& localeIdentifier, unsigned consecutiveHyphenatedLines, int consecutiveHyphenatedLinesLimit, int minimumPrefixLimit, int minimumSuffixLimit, unsigned lastSpace, unsigned pos, float xPos, float availableWidth, bool isFixedPitch, bool collapseWhiteSpace, int lastSpaceWordSpacing, InlineIterator& lineBreak, std::optional<unsigned> nextBreakable, bool& hyphenated)
Someone should make this take a struct instead of million arguments.
WebKit Commit Bot
Comment 3
2017-03-14 14:58:43 PDT
Comment on
attachment 304405
[details]
Patch Clearing flags on attachment: 304405 Committed
r213944
: <
http://trac.webkit.org/changeset/213944
>
WebKit Commit Bot
Comment 4
2017-03-14 14:58:49 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug