Bug 169617 - Simple line layout: Adjust hyphenation constrains based on the normal line layout line-breaking logic.
Summary: Simple line layout: Adjust hyphenation constrains based on the normal line la...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-14 11:27 PDT by zalan
Modified: 2017-03-14 14:58 PDT (History)
5 users (show)

See Also:


Attachments
Patch (8.68 KB, patch)
2017-03-14 11:37 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-03-14 11:27:24 PDT
There are fractional differences with enlarged font size.
Comment 1 zalan 2017-03-14 11:37:38 PDT
Created attachment 304405 [details]
Patch
Comment 2 Antti Koivisto 2017-03-14 13:26:20 PDT
Comment on attachment 304405 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304405&action=review

> Source/WebCore/rendering/line/BreakingContext.h:665
> +inline void tryHyphenating(RenderText& text, const FontCascade& font, const AtomicString& localeIdentifier, unsigned consecutiveHyphenatedLines, int consecutiveHyphenatedLinesLimit, int minimumPrefixLimit, int minimumSuffixLimit, unsigned lastSpace, unsigned pos, float xPos, float availableWidth, bool isFixedPitch, bool collapseWhiteSpace, int lastSpaceWordSpacing, InlineIterator& lineBreak, std::optional<unsigned> nextBreakable, bool& hyphenated)

Someone should make this take a struct instead of million arguments.
Comment 3 WebKit Commit Bot 2017-03-14 14:58:43 PDT
Comment on attachment 304405 [details]
Patch

Clearing flags on attachment: 304405

Committed r213944: <http://trac.webkit.org/changeset/213944>
Comment 4 WebKit Commit Bot 2017-03-14 14:58:49 PDT
All reviewed patches have been landed.  Closing bug.